From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 52989 invoked by alias); 23 Jun 2015 12:48:46 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 52980 invoked by uid 89); 23 Jun 2015 12:48:46 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=0.4 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_NONE autolearn=no version=3.3.2 X-HELO: bin-vsp-out-03.atm.binero.net Received: from vsp-authed01.binero.net (HELO bin-vsp-out-03.atm.binero.net) (195.74.38.224) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 23 Jun 2015 12:48:45 +0000 X-Halon-ID: f06d775d-19a5-11e5-8f39-0050569116f7 Authorized-sender: support@gaisler.com Received: from [192.168.0.86] (unknown [81.170.187.120]) by bin-vsp-out-03.atm.binero.net (Halon Mail Gateway) with ESMTPSA; Tue, 23 Jun 2015 14:46:59 +0200 (CEST) Message-ID: <558955AD.9020101@gaisler.com> Date: Tue, 23 Jun 2015 12:55:00 -0000 From: Daniel Cederman User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Jakub Jelinek CC: gcc-patches@gcc.gnu.org, daniel@gaisler.com, ebotcazou@adacore.com, Sebastian Huber Subject: Re: [PATCH] Make muser-mode the default for LEON3 References: <1435062156-28097-1-git-send-email-cederman@gaisler.com> <1435062156-28097-2-git-send-email-cederman@gaisler.com> <20150623123448.GP10247@tucnak.redhat.com> In-Reply-To: <20150623123448.GP10247@tucnak.redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-06/txt/msg01545.txt.bz2 On 2015-06-23 14:34, Jakub Jelinek wrote: > On Tue, Jun 23, 2015 at 02:22:34PM +0200, Daniel Cederman wrote: >> The muser-mode flag causes the CASA instruction for LEON3 to use the >> user mode ASI. This is the correct behavior for almost all LEON3 targets. >> For this reason it makes sense to make user mode the default. This patch >> adds a flag for supervisor mode that can be used on the very few LEON3 targets >> that requires CASA to use the supervisor ASI. > > Why are you adding a new option and without deprecation removing a > previously accepted (at least since 4.8) option? > For just changing the default, you really don't need to add a new option > or remove -mno-user-mode, just change the default, which can be done > e.g. by checking if the bit has been explicitly set and if not, use the > desired default, or if you want to change the Mask() name, just > make it InverseMask, but keep the options as they are. > > Jakub > How does one check if the bit has been explicitly set? It was not obvious to me, which is why I took a similar approach to a patch I found for another CPU target. If it is possible to change the default without adding another flag then that is obviously better and I will update my patch. Best regards, Daniel Cederman