Re: [patch] Delete temporary response file

[Jeff Law <law@redhat.com>]

On 06/22/2015 11:37 AM, Eric Botcazou wrote:
> Hi,
>
> when you pass a response file at link time and you use the GNU linker, then
> collect2 creates another, temporary response file and passes it to the linker.
> But it fails to delete the file after it is done.  This can easily be seen
> with the following manipulation:
>
> eric@polaris:~/build/gcc/native> cat t.c
> int main (void) { return 0; }
> eric@polaris:~/build/gcc/native> cat t.resp
> -L/usr/lib64
> eric@polaris:~/build/gcc/native> gcc -c t.c
> eric@polaris:~/build/gcc/native> export TMPDIR=$PWD
> eric@polaris:~/build/gcc/native> gcc -o t t.o @t.resp
> eric@polaris:~/build/gcc/native> ls cc*
> ccVSQ6W5
>
> The problem is that do_wait is not invoked by tlink_execute, only collect_wait
> is, so the cleanup code present therein is never invoked.
>
> Tested on x86_64-suse-linux, OK for the mainline?
>
>
> 2015-06-22  Tristan Gingold  <gingold@adacore.com>
>
> 	* collect2.c (collect_wait): Unlink the response file here instead of...
> 	(do_wait): ...here.
> 	(utils_cleanup): ...and here.
OK.
jeff