From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 98678 invoked by alias); 25 Jun 2015 16:16:26 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 98665 invoked by uid 89); 25 Jun 2015 16:16:26 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.1 required=5.0 tests=AWL,BAYES_50,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 25 Jun 2015 16:16:23 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id D4F8636507B for ; Thu, 25 Jun 2015 16:16:21 +0000 (UTC) Received: from localhost.localdomain (ovpn-113-49.phx2.redhat.com [10.3.113.49]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t5PGGL6W006547; Thu, 25 Jun 2015 12:16:21 -0400 Message-ID: <558C2955.6000302@redhat.com> Date: Thu, 25 Jun 2015 16:18:00 -0000 From: Jeff Law User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Andrew MacLeod , gcc-patches Subject: Re: [patch 2/4] Remove tm.h and options.h as dependencies for function.h References: <558C004E.2070809@redhat.com> In-Reply-To: <558C004E.2070809@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-06/txt/msg01824.txt.bz2 On 06/25/2015 07:21 AM, Andrew MacLeod wrote: > This patch finally removes tm.h as a compile dependency for function.h > > struct incoming_args was declared in function.h, and had an instance of > CUMULATIVE_ARGS from tm.h The only consumer of incoming_args is > rtl-data which is now located in emit-rtl.h, so I moved the decl to there. > > The remaining dependencies were pointers to CUMULATIVE_ARGS being used > as parameters to 2 functions pass_by_reference and > reference_callee_copied. I moved these 2 functions to calls.[ch]. The > vast majority of consumers are in the backend, and already include/need > calls.h, so it seemed a sensible location. > > This allows tm.h and hard-reg-set.h to be removed from cfgloop.h. On my > flattened branch, compiler back-end files requiring hard-reg-set.h > dropped from 270ish to 98, and it ought to have a decent impact on the > front end files when I get to them. > > Bootstraps on x86_64-unknown-linux-gnu with no new regressions. Also > builds stage 1 on all the targets in config-list.mk. > > OK for trunk? > > Andrew > > > 2-func-tm.patch > > > * function.h (struct incoming_args): Move struct. > (pass_by_reference, reference_callee_copied): Remove prototypes. > * emit-rtl.h (struct incoming_args): Relocate struct here. > * calls.h (pass_by_reference, reference_callee_copied): Relocate > prototypes here. > * function.c (pass_by_reference, reference_callee_copied): Move. > * calls.c (pass_by_reference, reference_callee_copied): Relocate here. > * cfgloop.h: Don't include tm.h or hard-reg-set.h. > * ipa-chkp.c: Include calls.h. > * ada/gcc-interface/misc.c: Include calls.h not function.h. > * c-family/cilk.c: Move calls.h after tm.h in the include chain. OK. jeff