From: Richard Earnshaw <Richard.Earnshaw@foss.arm.com>
To: Thomas Preud'homme <Thomas.Preudhomme@arm.com>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
Ramana Radhakrishnan <Ramana.Radhakrishnan@arm.com>,
Kyrylo Tkachov <Kyrylo.Tkachov@arm.com>
Subject: Re: [PATCH, ARM] Restrict pr65647 testcase to ARMv6-M effective target
Date: Fri, 26 Jun 2015 08:57:00 -0000 [thread overview]
Message-ID: <558D1259.8090803@foss.arm.com> (raw)
In-Reply-To: <003001d0afec$6de65a60$49b30f20$@arm.com>
On 26/06/15 09:45, Thomas Preud'homme wrote:
> Hi,
>
> Testcase for PR65647 assumes that the compiler can compile for ARMv6-M
> which might not be the case if passing some extra options via
> RUNTESTFLAGS (eg. -marm/-mcpu=cortex-a9). This patch restricts the
> testcase to ARMv6-M effective targets.
>
>
> Testsuite ChangeLog entry is as follows:
>
> 2015-06-25 Thomas Preud'homme <thomas.preudhomme@arm.com>
>
> * gcc.target/arm/pr65647.c: Restrict to ARMv6-M effective targets.
>
>
> diff --git a/gcc/testsuite/gcc.target/arm/pr65647.c b/gcc/testsuite/gcc.target/arm/pr65647.c
> index d3b44b2..d828d23 100644
> --- a/gcc/testsuite/gcc.target/arm/pr65647.c
> +++ b/gcc/testsuite/gcc.target/arm/pr65647.c
> @@ -1,4 +1,5 @@
> /* { dg-do compile } */
> +/* { dg-require-effective-target arm_arch_v6m_ok } */
> /* { dg-options "-march=armv6-m -mthumb -O3 -w -mfloat-abi=soft" } */
>
> a, b, c, e, g = &e, h, i = 7, l = 1, m, n, o, q = &m, r, s = &r, u, w = 9, x,
>
>
> Patch was tested by running the testcase once with -mcpu=cortex-a9
> (skipped as expected) and once with -mcpu=cortex-m0 (passes).
>
> Is this ok for trunk?
>
OK.
R.
> Best regards,
>
> Thomas
>
>
next prev parent reply other threads:[~2015-06-26 8:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-26 8:47 Thomas Preud'homme
2015-06-26 8:57 ` Richard Earnshaw [this message]
2015-06-26 10:17 ` James Greenhalgh
2015-06-26 10:51 ` Thomas Preud'homme
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=558D1259.8090803@foss.arm.com \
--to=richard.earnshaw@foss.arm.com \
--cc=Kyrylo.Tkachov@arm.com \
--cc=Ramana.Radhakrishnan@arm.com \
--cc=Thomas.Preudhomme@arm.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).