From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26073 invoked by alias); 29 Jun 2015 19:46:49 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 26060 invoked by uid 89); 29 Jun 2015 19:46:48 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 29 Jun 2015 19:46:47 +0000 Received: from nat-ies.mentorg.com ([192.94.31.2] helo=SVR-IES-FEM-01.mgc.mentorg.com) by relay1.mentorg.com with esmtp id 1Z9f0t-0007EQ-25 from Bernd_Schmidt@mentor.com ; Mon, 29 Jun 2015 12:46:43 -0700 Received: from [127.0.0.1] (137.202.0.76) by SVR-IES-FEM-01.mgc.mentorg.com (137.202.0.104) with Microsoft SMTP Server id 14.3.224.2; Mon, 29 Jun 2015 20:46:41 +0100 Message-ID: <5591A09A.5050903@codesourcery.com> Date: Mon, 29 Jun 2015 20:06:00 -0000 From: Bernd Schmidt User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Chen Gang , Jeff Law , Richard Henderson , CC: gcc-patches List Subject: Re: [PATCH] config/bfin/bfin.c (hwloop_optimize): Use return false instead of gcc_assert for checking jump_insn. References: In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2015-06/txt/msg02114.txt.bz2 On 06/28/2015 04:15 PM, Chen Gang wrote: > For bfin looping optimization, after lsetup optimization, it can have > the correct lsetup related insns which causes gcc_assert for jump_insn. I've been debugging this for a bit, and at least the explanation of the patch is wrong - it's finding an LSETUP for a different loop. There seems to be an inconsistency in the CFG, and it looks like it's caused by the unusual (?) situation that both arms out of a conditional branch lead directly to a hwloop candidate. So, not OK until further investigation I think. Bbernd