From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 128811 invoked by alias); 30 Jun 2015 06:11:11 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 128800 invoked by uid 89); 30 Jun 2015 06:11:10 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.2 X-HELO: out4-smtp.messagingengine.com Received: from out4-smtp.messagingengine.com (HELO out4-smtp.messagingengine.com) (66.111.4.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 30 Jun 2015 06:11:09 +0000 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id D19FC20BBE for ; Tue, 30 Jun 2015 02:11:06 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute3.internal (MEProxy); Tue, 30 Jun 2015 02:11:06 -0400 Received: from [192.168.0.14] (unknown [178.83.163.235]) by mail.messagingengine.com (Postfix) with ESMTPA id B0DE6C0028C; Tue, 30 Jun 2015 02:11:05 -0400 (EDT) Message-ID: <559232F5.4040206@grosser.es> Date: Tue, 30 Jun 2015 06:11:00 -0000 From: Tobias Grosser User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Sebastian Pop , Aditya Kumar CC: GCC Patches Subject: Re: [PATCH] Discard Scops for which entry==exit References: <1435608255-10186-1-git-send-email-hiraditya@msn.com> In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2015-06/txt/msg02145.txt.bz2 On 06/30/2015 02:09 AM, Sebastian Pop wrote: > On Mon, Jun 29, 2015 at 3:04 PM, Aditya Kumar wrote: >> In this patch we discard the scops where entry and exit are the same BB. >> This is an effort to remove graphite-scop-detection.c:limit_scops. >> Removing the limit_scops function introduces correctness regressions. >> We are making relevant changes in incremental steps to fix those bugs, >> and finally we intend to remove limit_scops. >> >> 2015-06-29 Aditya Kumar >> Sebastian Pop >> >> * graphite-scop-detection.c (build_scops_1): Discard scops for which entry==exit > > Looks good to me. > Let's wait on comments from Tobi before pushing this patch. Hi Sebastian, the commit message should probably give a short reasoning why scops with entry == exit need to be discarded. I currently don't see why they would be incorrect/problematic (despite being possibly very small/empty). Tobias