From: Tobias Grosser <tobias@grosser.es>
To: Sebastian Pop <sebpop@gmail.com>, Aditya Kumar <hiraditya@msn.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] Graphite cannot handle return stmt
Date: Tue, 30 Jun 2015 06:43:00 -0000 [thread overview]
Message-ID: <5592335B.7090806@grosser.es> (raw)
In-Reply-To: <CAFk3UF9B1N9qkEvWf8EmjQfJso6WFk+_YpqyTf+HVmyTqDf1-g@mail.gmail.com>
On 06/30/2015 02:12 AM, Sebastian Pop wrote:
> On Mon, Jun 29, 2015 at 3:58 PM, Aditya Kumar <hiraditya@msn.com> wrote:
>> No regressions.
>>
>> 2015-06-29 Aditya Kumar <aditya.k7@samsung.com>
>> Sebastian Pop <s.pop@samsung.com>
>>
>> * graphite-scop-detection.c (stmt_simple_for_scop_p): Bail out in case of a return statement.
>
> Looks good to me.
> Tobi, do you see a good reason not to cut scops at return stmts?
Return stmts in a SCoP are definitely invalid. Now, as in my last email,
I wonder why this is not a positive list. There are probably a lot of
gimple codes that are invalid inside scops. By default we should refuse
everything we do _not_ know.
Best,
Tobias
next prev parent reply other threads:[~2015-06-30 6:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-29 21:33 Aditya Kumar
2015-06-30 0:43 ` Sebastian Pop
2015-06-30 6:43 ` Tobias Grosser [this message]
2015-06-30 8:16 ` Richard Biener
[not found] <1435611532-31080-1-git-send-email-hiraditya at msn dot com>
2015-06-30 20:55 ` Aditya Kumar
2015-07-02 7:52 ` Tobias Grosser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5592335B.7090806@grosser.es \
--to=tobias@grosser.es \
--cc=gcc-patches@gcc.gnu.org \
--cc=hiraditya@msn.com \
--cc=sebpop@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).