From: Xi Ruoyao <xry111@xry111.site>
To: Caroline Tice <cmtice@google.com>, Lulu Cheng <chenglulu@loongson.cn>
Cc: xuchenghua@loongson.cn, qijingwen <qijingwen@loongson.cn>,
GCC Patches <gcc-patches@gcc.gnu.org>,
i@xen0n.name
Subject: Re: [PATCH v2] LoongArch: Libvtv add loongarch support.
Date: Tue, 11 Oct 2022 17:41:35 +0800 [thread overview]
Message-ID: <55938bca6979a2f82f6861243a820a67f106db64.camel@xry111.site> (raw)
In-Reply-To: <CABtf2+Ts-XL2HmdebtmSFTKaMZQ2HrAyuj1asGUUghTO6bq20Q@mail.gmail.com>
On Mon, 2022-10-10 at 10:49 -0700, Caroline Tice via Gcc-patches wrote:
> Is "if (VTV_PAGE_SIZE != sysconf (_SC_PAGE_SIZE))" going to fail for
> loongarch?
Because LoongArch systems may have 4KB, 16KB, or 64KB pages.
> If not, why do you need to insert anything here at all? If so,
> perhaps you could write something similar to sysconf_SC_PAGE_SIZE for
> loongarch (as was done for __CYGWIN__ & __MINGW32__)?
I'd like to ask a question: if we set VTV_PAGE_SIZE to 64KB and make the
special case, will libvtv work for 4KB and 16KB pages? (If I read code
correctly, setting VTV_PAGE_SIZE to 4KB will obviously break 16KB or
64KB configuration.)
If VTV_PAGE_SIZE == sysconf (_SC_PAGE_SIZE) is strictly required for
libvtv we'll have to keep the check as-is and then we'll only support
16KB page configuration (which is the default in Linux kernel
configuration for LoongArch).
--
Xi Ruoyao <xry111@xry111.site>
School of Aerospace Science and Technology, Xidian University
next prev parent reply other threads:[~2022-10-11 9:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-27 7:49 Lulu Cheng
2022-09-27 11:44 ` Xi Ruoyao
2022-09-28 7:29 ` Lulu Cheng
2022-10-10 17:49 ` Caroline Tice
2022-10-11 9:41 ` Xi Ruoyao [this message]
2022-10-11 20:57 ` Caroline Tice
2022-10-12 2:52 ` Lulu Cheng
2022-10-12 4:05 ` Caroline Tice
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55938bca6979a2f82f6861243a820a67f106db64.camel@xry111.site \
--to=xry111@xry111.site \
--cc=chenglulu@loongson.cn \
--cc=cmtice@google.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=i@xen0n.name \
--cc=qijingwen@loongson.cn \
--cc=xuchenghua@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).