From: Jeff Law <law@redhat.com>
To: Richard Biener <richard.guenther@gmail.com>,
GCC Patches <gcc-patches@gcc.gnu.org>,
segher@kernel.crashing.org, richard.sandiford@arm.com
Subject: Re: PR 66685: parallel returns being misclassified
Date: Wed, 01 Jul 2015 16:45:00 -0000 [thread overview]
Message-ID: <5594194F.6080801@redhat.com> (raw)
In-Reply-To: <87zj3fnbmt.fsf@e105548-lin.cambridge.arm.com>
On 07/01/2015 09:25 AM, Richard Sandiford wrote:
> Richard Biener <richard.guenther@gmail.com> writes:
>> On Wed, Jul 1, 2015 at 10:27 AM, Richard Sandiford
>> <richard.sandiford@arm.com> wrote:
>>> This patch should restore bootstrap on hppa (and probably other targets
>>> besides). The change to use target-insns.def put more stress on the
>>> emit()/classify_insn() group of functions, which were missing a case
>>> for parallel returns.
>>>
>>> Tested with a cross-compiler that it fixes the hppa problem. Bootstrap
>>> in progress on x86_64-linux-gnu. OK to install?
>>
>> Ok.
>
> I think this has probably broken bootstrap on powerpc64, where sibcalls
> have both calls and returns. The loop picks the last candidate,
> which is the return.
>
> Is this patch OK?
>
> Thanks,
> Richard
>
> gcc/
> PR bootstrap/66685
> * rtl.c (classify_insn): Only return JUMP_INSN for parallel returns if
> there are no CALLs in the same pattern.
OK.
jeff
prev parent reply other threads:[~2015-07-01 16:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-01 8:27 Richard Sandiford
2015-07-01 8:35 ` Richard Biener
2015-07-01 15:25 ` Richard Sandiford
2015-07-01 16:45 ` Jeff Law [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5594194F.6080801@redhat.com \
--to=law@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=richard.guenther@gmail.com \
--cc=richard.sandiford@arm.com \
--cc=segher@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).