From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20364 invoked by alias); 1 Jul 2015 16:45:59 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 20353 invoked by uid 89); 1 Jul 2015 16:45:59 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 01 Jul 2015 16:45:58 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id E7E2436B188; Wed, 1 Jul 2015 16:45:56 +0000 (UTC) Received: from localhost.localdomain (ovpn-113-49.phx2.redhat.com [10.3.113.49]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t61GjuDr028231; Wed, 1 Jul 2015 12:45:56 -0400 Message-ID: <5594194F.6080801@redhat.com> Date: Wed, 01 Jul 2015 16:45:00 -0000 From: Jeff Law User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Richard Biener , GCC Patches , segher@kernel.crashing.org, richard.sandiford@arm.com Subject: Re: PR 66685: parallel returns being misclassified References: <87h9ponuzs.fsf@e105548-lin.cambridge.arm.com> <87zj3fnbmt.fsf@e105548-lin.cambridge.arm.com> In-Reply-To: <87zj3fnbmt.fsf@e105548-lin.cambridge.arm.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-07/txt/msg00061.txt.bz2 On 07/01/2015 09:25 AM, Richard Sandiford wrote: > Richard Biener writes: >> On Wed, Jul 1, 2015 at 10:27 AM, Richard Sandiford >> wrote: >>> This patch should restore bootstrap on hppa (and probably other targets >>> besides). The change to use target-insns.def put more stress on the >>> emit()/classify_insn() group of functions, which were missing a case >>> for parallel returns. >>> >>> Tested with a cross-compiler that it fixes the hppa problem. Bootstrap >>> in progress on x86_64-linux-gnu. OK to install? >> >> Ok. > > I think this has probably broken bootstrap on powerpc64, where sibcalls > have both calls and returns. The loop picks the last candidate, > which is the return. > > Is this patch OK? > > Thanks, > Richard > > gcc/ > PR bootstrap/66685 > * rtl.c (classify_insn): Only return JUMP_INSN for parallel returns if > there are no CALLs in the same pattern. OK. jeff