From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 99786 invoked by alias); 1 Jul 2015 17:35:51 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 99761 invoked by uid 89); 1 Jul 2015 17:35:50 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 01 Jul 2015 17:35:49 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id 8B036AED62; Wed, 1 Jul 2015 17:35:48 +0000 (UTC) Received: from localhost.localdomain (ovpn-113-49.phx2.redhat.com [10.3.113.49]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t61HZlsC029565; Wed, 1 Jul 2015 13:35:48 -0400 Message-ID: <559424FF.3030008@redhat.com> Date: Wed, 01 Jul 2015 17:35:00 -0000 From: Jeff Law User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: David Malcolm CC: gcc-patches@gcc.gnu.org, jit@gcc.gnu.org Subject: Re: [PATCH 1/2] Add gcc/typed-splay-tree.h References: <558A846C.70003@starynkevitch.net> <1435259621-45194-1-git-send-email-dmalcolm@redhat.com> <558C53EA.2040706@redhat.com> <1435599418.13727.144.camel@surprise> In-Reply-To: <1435599418.13727.144.camel@surprise> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-07/txt/msg00069.txt.bz2 On 06/29/2015 11:36 AM, David Malcolm wrote: > On Thu, 2015-06-25 at 13:18 -0600, Jeff Law wrote: >> On 06/25/2015 01:13 PM, David Malcolm wrote: >>> I found when implementing switch statements for the jit that it >>> was much easier to work with libiberty's splay-tree.h by first >>> wrapping it in a C++ wrapper to add typesafety. >>> >>> This patch adds such a wrapper, implementing the methods I needed. >>> >>> It's unused in this patch, but is used in the followup patch (which only >>> touches the jit). >>> >>> OK for trunk? >>> >>> gcc/ChangeLog: >>> * typed-splay-tree.h: New file. >> OK. > > Well, this is embarrassing, it seems the patch I posted to the list > doesn't actually compile. It happens. It's one of the reasons why we have the rules around bootstrap testing :-) I can't count how many of these kinds of goofs I've made through the years. > > The underlying splay_tree_insert returns a splay_tree_node, I had the > typed_splay_tree::insert returning a value_type. I dropped this bogus > return type from the "insert" method in the implementation, in favor of > "void", but I forgot to update the declaration, leading to errors when > attempting to actually compile this (via jit/jit-recording.c in the > followup patch). > > The attached one-liner patch drops it from the declaration, and applies > to [PATCH 1/2]. I don't know if I can count this as "obvious"... It > does compile now, and "make check-jit" looks good. I'd think this qualifies :-) jeff