public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Ramana Radhakrishnan <ramana.radhakrishnan@foss.arm.com>
To: gcc-patches@gcc.gnu.org
Subject: Re: [Patch, ARM]: remove TARGET_ASM_FILE_START_APP_OFF
Date: Mon, 06 Jul 2015 15:15:00 -0000	[thread overview]
Message-ID: <559A9B7C.6030502@foss.arm.com> (raw)
In-Reply-To: <5592867A.8000908@st.com>



On 30/06/15 13:07, Christian Bruel wrote:
> Hi,
> 
> A little bit of polishing around arm/thumb attribute_target emission and testing: Since the arch mode is emitted for each function, the file setting becomes useless or redundant.
> 
> for example with attr_thumb.c:
> 
> =>    .arm
> =>    .syntax divided
>     .file    "attr_thumb.c"
>     .text
>     .align    2
>     .global    foo
> =>    .syntax unified
> =>    .code    16
>     .thumb_func
>     .type    foo, %function
> 
> This patch cleans this up and relaxes the attribute target tests to run on any thumb1/thumb2.
> 
> no new failure on arm-cortex-linux-gnueabi
> 
> and arm-none-eabi for
>       arm-sim/
>       arm-sim//-march=armv7-a
>       arm-sim//-mthumb
>       arm-sim//-mthumb/-march=armv7-a
>       arm-sim/-mflip-thumb/
>       arm-sim/-mflip-thumb//-march=armv7-a
>       arm-sim/-mflip-thumb//-mthumb
>       arm-sim/-mflip-thumb//-mthumb/-march=armv7-a
> 
> is still running but OK so far. OK for trunk once done ?

OK.


regards
Ramana

> 
> many thanks,
> 
> Christian
> 
> 

      parent reply	other threads:[~2015-07-06 15:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-30 12:19 Christian Bruel
2015-07-06 11:52 ` [PATCH, ARM]: PING " Christian Bruel
2015-07-06 15:15 ` Ramana Radhakrishnan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=559A9B7C.6030502@foss.arm.com \
    --to=ramana.radhakrishnan@foss.arm.com \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).