From: Mikhail Maltsev <maltsevm@gmail.com>
To: gcc-patches <gcc-patches@gnu.org>, Jason Merrill <jason@redhat.com>
Subject: [PATCH 4/7] Fix int overflow
Date: Mon, 06 Jul 2015 19:28:00 -0000 [thread overview]
Message-ID: <559AD8CA.8030209@gmail.com> (raw)
In-Reply-To: <559AD66D.1070809@gmail.com>
---
libiberty/cp-demangle.c | 3 ++-
libiberty/testsuite/demangle-expected | 4 ++++
2 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/libiberty/cp-demangle.c b/libiberty/cp-demangle.c
index 44a0a9b..befa6b6 100644
--- a/libiberty/cp-demangle.c
+++ b/libiberty/cp-demangle.c
@@ -103,6 +103,7 @@
#include "config.h"
#endif
+#include <limits.h>
#include <stdio.h>
#ifdef HAVE_STDLIB_H
@@ -1599,7 +1600,7 @@ d_source_name (struct d_info *di)
struct demangle_component *ret;
len = d_number (di);
- if (len <= 0)
+ if (len <= 0 || len > INT_MAX)
return NULL;
ret = d_identifier (di, len);
di->last_name = ret;
diff --git a/libiberty/testsuite/demangle-expected
b/libiberty/testsuite/demangle-expected
index 47ca8f5..9a8d3db 100644
--- a/libiberty/testsuite/demangle-expected
+++ b/libiberty/testsuite/demangle-expected
@@ -4096,6 +4096,10 @@ std::complex<int>::real[abi:cxx11]() const
--format=gnu-v3
Av32_f
Av32_f
+# Check range when converting from long to int
+--format=gnu-v3
+_Z11111111111
+_Z11111111111
#
# Ada (GNAT) tests.
#
--
1.8.3.1
next prev parent reply other threads:[~2015-07-06 19:28 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-06 19:18 [PATCH 0/7] Fix bugs found during demangler fuzz-testing Mikhail Maltsev
2015-07-06 19:22 ` [PATCH 1/7] Add CHECK_DEMANGLER Mikhail Maltsev
2015-07-06 22:50 ` Jeff Law
2015-07-06 19:24 ` [PATCH 2/7] Fix build with CP_DEMANGLE_DEBUG Mikhail Maltsev
2015-07-06 22:19 ` Jeff Law
2015-07-06 19:26 ` [PATCH 3/7] Fix trinary op Mikhail Maltsev
2015-07-07 22:39 ` Jeff Law
2015-07-08 10:55 ` Ian Lance Taylor
2015-07-08 13:42 ` Tom Tromey
2015-07-08 13:46 ` Ian Lance Taylor
2015-07-10 4:50 ` Mikhail Maltsev
2015-07-10 20:44 ` Jeff Law
2015-07-13 5:54 ` Mikhail Maltsev
2015-07-06 19:28 ` Mikhail Maltsev [this message]
2015-07-06 22:55 ` [PATCH 4/7] Fix int overflow Jeff Law
2015-07-07 0:05 ` Mikhail Maltsev
2015-07-07 22:48 ` Jeff Law
2015-07-08 3:58 ` Mikhail Maltsev
2015-07-08 10:52 ` Ian Lance Taylor
2015-07-06 19:28 ` [PATCH 5/7] Fix braced-init-list demangling Mikhail Maltsev
2015-07-06 22:58 ` Jeff Law
2015-07-06 19:31 ` [PATCH 6/7] Fix DEMANGLE_COMPONENT_LOCAL_NAME Mikhail Maltsev
2015-07-07 22:40 ` Jeff Law
2015-07-06 19:32 ` [PATCH 7/7] Fix several crashes in d_find_pack Mikhail Maltsev
2015-07-07 22:50 ` Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=559AD8CA.8030209@gmail.com \
--to=maltsevm@gmail.com \
--cc=gcc-patches@gnu.org \
--cc=jason@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).