From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 43835 invoked by alias); 6 Jul 2015 20:08:33 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 43823 invoked by uid 89); 6 Jul 2015 20:08:32 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 06 Jul 2015 20:08:30 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id D9C9491C1B; Mon, 6 Jul 2015 20:08:28 +0000 (UTC) Received: from localhost.localdomain (ovpn-113-49.phx2.redhat.com [10.3.113.49]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t66K8RZi023654; Mon, 6 Jul 2015 16:08:28 -0400 Message-ID: <559AE050.8010200@redhat.com> Date: Mon, 06 Jul 2015 20:08:00 -0000 From: Jeff Law User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Ajit Kumar Agarwal , Joseph Myers CC: GCC Patches , Vinod Kathail , Shail Aditya Gupta , Vidhumouli Hunsigida , Nagaraju Mekala Subject: Re: [Patch,tree-optimization]: Add new path Splitting pass on tree ssa representation References: <37378DC5BCD0EE48BA4B082E0B55DFAA41F3F56C@XAP-PVEXMBX02.xlnx.xilinx.com> <37378DC5BCD0EE48BA4B082E0B55DFAA41F403C4@XAP-PVEXMBX02.xlnx.xilinx.com> In-Reply-To: <37378DC5BCD0EE48BA4B082E0B55DFAA41F403C4@XAP-PVEXMBX02.xlnx.xilinx.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-07/txt/msg00408.txt.bz2 On 07/01/2015 09:51 PM, Ajit Kumar Agarwal wrote: > > > -----Original Message----- > From: Joseph Myers [mailto:joseph@codesourcery.com] > Sent: Wednesday, July 01, 2015 3:48 AM > To: Ajit Kumar Agarwal > Cc: law@redhat.com; GCC Patches; Vinod Kathail; Shail Aditya Gupta; Vidhumouli Hunsigida; Nagaraju Mekala > Subject: Re: [Patch,tree-optimization]: Add new path Splitting pass on tree ssa representation > > On Tue, 30 Jun 2015, Ajit Kumar Agarwal wrote: > >> * gcc/common.opt: Add the new flag ftree-path-split. > >>> All options need documenting in invoke.texi. > > Sure. >> +#include "tm.h" > >>> Why? Does some other header depend on this, or are you using a target macro? > > I am not using any target macro. There are many header files that includes the tm.h and also there are many tree-ssa optimization > files that have included "tm.h" listing some of them tree-ssa-threadupdate.c tree-vrp.c , tree-ssa-threadedge.c. > But the question is do you actually need "tm.h" -- we're in the middle of a project to better separate the front ends from the gimple optimizers from the RTL optimizers & backends. Including "tm.h" in places where it's not really needed makes achieving and maintaining the separation harder than it should be. In general we should only be including the header files that are actually needed. Jeff