public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Pedro Alves <alves.ped@gmail.com>
To: Martin Sebor <msebor@gmail.com>,
	 Gcc Patch List <gcc-patches@gcc.gnu.org>
Subject: Re: [PING 3] Re: [PATCH]  warn for unsafe calls to __builtin_return_address
Date: Tue, 07 Jul 2015 10:14:00 -0000	[thread overview]
Message-ID: <559BA67C.7020304@gmail.com> (raw)
In-Reply-To: <559B4A67.6070201@gmail.com>

On 07/07/2015 04:41 AM, Martin Sebor wrote:
> This is a small change to diagnose unsafe calls to
> __builtin_{frame,return}_address (with an argument > 2) than
> tend to return bogus values or lead to crashes at runtime.
> 

I hadn't realized you went through and implemented the
suggestion.  Thanks for doing this.  I hope it gets approved.

> A review would be appreciated.

(It may be the relevant maintainers haven't noticed there's a
code patch here because this is nested within
the "[PATCH] clarify doc for __builtin_return_address" thread).)

Thanks,
Pedro Alves

  reply	other threads:[~2015-07-07 10:14 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-21 19:37 [PATCH] clarify doc for __builtin_return_address Martin Sebor
2015-05-21 20:50 ` Sandra Loosemore
2015-05-21 21:22   ` Martin Sebor
2015-05-21 22:00 ` Pedro Alves
2015-06-11 23:22   ` [PATCH] warn for unsafe calls to __builtin_return_address Martin Sebor
2015-06-18 17:32     ` [PING] " Martin Sebor
2015-06-27  0:48       ` [PING 2] " Martin Sebor
2015-07-07  3:41         ` [PING 3] " Martin Sebor
2015-07-07 10:14           ` Pedro Alves [this message]
2015-07-24  5:30     ` Jeff Law
2015-07-25 15:59       ` Segher Boessenkool
2015-07-28  3:44         ` Martin Sebor
2015-07-28 15:19           ` Segher Boessenkool
2015-07-28 16:03             ` Martin Sebor
2015-07-31 16:46               ` Jeff Law
2015-08-02 23:15                 ` Martin Sebor
2015-08-03 11:55                   ` [BUILDROBOT] Go runtime: calling ‘__builtin_frame_address’ with a nonzero argument is unsafe (was: warn for unsafe calls to __builtin_return_address) Jan-Benedict Glaw
2015-08-03 14:48                     ` [BUILDROBOT] Go runtime: calling ‘__builtin_frame_address’ with a nonzero argument is unsafe Martin Sebor
2015-08-03 15:29                       ` Jeff Law
2015-08-05  7:28               ` [PATCH] warn for unsafe calls to __builtin_return_address Andreas Schwab
2015-08-05 16:03               ` Jiong Wang
2015-08-05 17:56                 ` Martin Sebor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=559BA67C.7020304@gmail.com \
    --to=alves.ped@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=msebor@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).