From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 84406 invoked by alias); 7 Jul 2015 22:50:03 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 84393 invoked by uid 89); 7 Jul 2015 22:50:02 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: fencepost.gnu.org Received: from fencepost.gnu.org (HELO fencepost.gnu.org) (208.118.235.10) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Tue, 07 Jul 2015 22:50:02 +0000 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46586) by fencepost.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ZCbgd-0000MY-To for gcc-patches@gnu.org; Tue, 07 Jul 2015 18:49:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZCbgY-000735-KO for gcc-patches@gnu.org; Tue, 07 Jul 2015 18:49:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38757) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZCbgY-00071u-FW for gcc-patches@gnu.org; Tue, 07 Jul 2015 18:49:54 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id 231473173E5; Tue, 7 Jul 2015 22:49:53 +0000 (UTC) Received: from localhost.localdomain (ovpn-113-49.phx2.redhat.com [10.3.113.49]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t67Mnqdu028345; Tue, 7 Jul 2015 18:49:52 -0400 Message-ID: <559C57A7.9000102@redhat.com> Date: Tue, 07 Jul 2015 22:50:00 -0000 From: Jeff Law User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Mikhail Maltsev , gcc-patches , Jason Merrill Subject: Re: [PATCH 7/7] Fix several crashes in d_find_pack References: <559AD66D.1070809@gmail.com> <559AD9C2.9000805@gmail.com> In-Reply-To: <559AD9C2.9000805@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 209.132.183.28 X-IsSubscribed: yes X-SW-Source: 2015-07/txt/msg00558.txt.bz2 On 07/06/2015 01:40 PM, Mikhail Maltsev wrote: > --- > libiberty/cp-demangle.c | 3 +++ > libiberty/testsuite/demangle-expected | 12 ++++++++++++ > 2 files changed, 15 insertions(+) > > diff --git a/libiberty/cp-demangle.c b/libiberty/cp-demangle.c > index 289a704..4ca285e 100644 > --- a/libiberty/cp-demangle.c > +++ b/libiberty/cp-demangle.c > @@ -4203,6 +4203,9 @@ d_find_pack (struct d_print_info *dpi, > case DEMANGLE_COMPONENT_CHARACTER: > case DEMANGLE_COMPONENT_FUNCTION_PARAM: > case DEMANGLE_COMPONENT_UNNAMED_TYPE: > + case DEMANGLE_COMPONENT_FIXED_TYPE: > + case DEMANGLE_COMPONENT_DEFAULT_ARG: > + case DEMANGLE_COMPONENT_NUMBER: > return NULL; > > case DEMANGLE_COMPONENT_EXTENDED_OPERATOR: > diff --git a/libiberty/testsuite/demangle-expected > b/libiberty/testsuite/demangle-expected > index cfa2691..b58cea2 100644 > --- a/libiberty/testsuite/demangle-expected > +++ b/libiberty/testsuite/demangle-expected > @@ -4108,6 +4108,18 @@ _ZDTtl > --format=gnu-v3 > _ZZN1fEEd_lEv > _ZZN1fEEd_lEv > +# Handle DEMANGLE_COMPONENT_FIXED_TYPE in d_find_pack > +--format=gnu-v3 > +DpDFT_ > +DpDFT_ > +# Likewise, DEMANGLE_COMPONENT_DEFAULT_ARG > +--format=gnu-v3 > +DpZ1fEd_ > +DpZ1fEd_ > +# Likewise, DEMANGLE_COMPONENT_NUMBER (??? result is probably still wrong) > +--format=gnu-v3 > +DpDv1_c > +(char __vector(1))... > # > # Ada (GNAT) tests. > # > OK with a suitable ChangeLog entry. FWIW, demangler.com doesn't give any results for that case. It just returns DpDv1_c Jeff