From: Jeff Law <law@redhat.com>
To: Kito Cheng <kito.cheng@gmail.com>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
richard.sandiford@arm.com
Subject: Re: Drop -Wswitch-bool warning in function.c
Date: Wed, 08 Jul 2015 21:00:00 -0000 [thread overview]
Message-ID: <559D8F87.4020402@redhat.com> (raw)
In-Reply-To: <CA+yXCZBWAydoV8e-Z0fy79Mw=ZHKVbBoeDQwX4xHjyyGkqyFQg@mail.gmail.com>
On 07/08/2015 02:49 AM, Kito Cheng wrote:
> Bootstrapped & regression-tested on x86_64-linux-gnu :)
>
> 2015-07-08 Kito Cheng <kito.cheng@gmail.com>
>
> * function.c (stack_protect_epilogue): Use if rather than switch for
> check targetm.have_stack_protect_test().
>
OK. Not necessarily because avoid the warning is really all that
important, but because the if-else is just as easy to read as the switch
and dramatically more compact.
Jeff
next prev parent reply other threads:[~2015-07-08 21:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-08 8:49 Kito Cheng
2015-07-08 13:30 ` Marek Polacek
2015-07-08 16:13 ` Kito Cheng
2015-07-09 6:55 ` Richard Sandiford
2015-07-08 21:00 ` Jeff Law [this message]
2015-07-09 3:26 ` Kito Cheng
2015-07-09 3:51 ` Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=559D8F87.4020402@redhat.com \
--to=law@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=kito.cheng@gmail.com \
--cc=richard.sandiford@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).