From: Jeff Law <law@redhat.com>
To: Jakub Jelinek <jakub@redhat.com>, mliska <mliska@suse.cz>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH 3/3] Fix ubsan tests by disabling of an optimization.
Date: Thu, 09 Jul 2015 15:34:00 -0000 [thread overview]
Message-ID: <559E9481.70505@redhat.com> (raw)
In-Reply-To: <20150709141312.GS10247@tucnak.redhat.com>
On 07/09/2015 08:13 AM, Jakub Jelinek wrote:
> On Thu, Jul 09, 2015 at 03:56:35PM +0200, mliska wrote:
>> ---
>> gcc/testsuite/g++.dg/ubsan/vptr-1.C | 2 +-
>> gcc/testsuite/g++.dg/ubsan/vptr-2.C | 2 +-
>> gcc/testsuite/g++.dg/ubsan/vptr-3.C | 2 +-
>> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> I'd actually think it would be better to give up on the
> UBSAN_* internal calls in tail merging. Those internal pass
> arguments based on their gimple_location, so tail merging breaks
> them.
So I think the larger question here is should differences in gimple
locations prevent tail merging? I'd tend to think not, which then begs
the question, are the UBSAN calls special enough to warrant an exception?
Jeff
next prev parent reply other threads:[~2015-07-09 15:34 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-09 14:10 [RFC, PATCH 0/3] tree-ssa-tail-merge engine replacement mliska
2015-07-09 14:10 ` [PATCH 2/3] Fully remove legacy tree-ssa-tail-merge value numbering infrastructure mliska
2015-07-09 15:38 ` Jeff Law
2015-07-10 9:31 ` Richard Biener
2015-07-09 14:10 ` [PATCH 3/3] Fix ubsan tests by disabling of an optimization mliska
2015-07-09 14:13 ` Jakub Jelinek
2015-07-09 15:34 ` Jeff Law [this message]
2015-07-09 15:42 ` Jakub Jelinek
2015-07-09 16:37 ` Jeff Law
2015-07-10 8:19 ` Richard Biener
2015-07-10 20:11 ` Jeff Law
2016-03-07 9:49 ` [PATCH] Skip ubsan internal fns in tail-merge Tom de Vries
2016-03-07 10:02 ` Jakub Jelinek
2016-03-07 11:26 ` Tom de Vries
2016-03-07 11:32 ` Jakub Jelinek
2016-03-07 11:56 ` Tom de Vries
2015-07-09 14:10 ` [PATCH 1/3] tree-ssa-tail-merge: add IPA ICF infrastructure mliska
2015-07-09 16:23 ` Jeff Law
2015-07-16 11:25 ` Martin Liška
2015-07-20 7:53 ` Martin Liška
2015-08-03 15:18 ` Martin Liška
2015-07-20 8:24 ` Martin Liška
2015-08-03 17:41 ` Jeff Law
2015-08-03 17:38 ` Jeff Law
2015-08-05 15:16 ` Martin Liška
2015-08-19 17:27 ` Jeff Law
2015-07-09 15:29 ` [RFC, PATCH 0/3] tree-ssa-tail-merge engine replacement Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=559E9481.70505@redhat.com \
--to=law@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=mliska@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).