Proposal to postpone release of 5.2 for a week [Was: Re: patch to fix PR66782]

Proposal to postpone release of 5.2 for a week [Was: Re: patch to fix PR66782]

[Uros Bizjak]

Hello!

> The patch was bootstrapped and tested on x86/x86-64.
>
> Committed as rev. 225618.
>
> 2015-07-09  Vladimir Makarov  <vmakarov@redhat.com>
>
>         PR rtl-optimization/66782
>         * lra-int.h (struct lra_insn_recog_data): Add comment about
>         clobbered hard regs for arg_hard_regs.
>         * lra.c (lra_set_insn_recog_data): Add clobbered hard regs.
>         * lra-lives.c (process_bb_lives): Process clobbered hard regs.
>         Add condition for processing used hard regs.
>         * lra-constraints.c (update_ebb_live_info, inherit_in_ebb):
>         Process clobbered hard regs.

I would like to nominate this patch for gcc-5.2 release. According to
downstream bugreport [1], gcc-5.1 is unusable for 64-bit wine:

"Breaks all of wine, no easy workaround -> blocker."

Due to severity of this bug, and importance of Wine, I'd like to
postpone the 5.2 release for a week, so this bug gets some testing in
the mainline, before it is backported to gcc-5 branch

[1] https://bugs.winehq.org/show_bug.cgi?id=38653

Uros.

Re: Proposal to postpone release of 5.2 for a week [Was: Re: patch to fix PR66782]

[Richard Biener]

On Thu, 9 Jul 2015, Uros Bizjak wrote:

> Hello!
> 
> > The patch was bootstrapped and tested on x86/x86-64.
> >
> > Committed as rev. 225618.
> >
> > 2015-07-09  Vladimir Makarov  <vmakarov@redhat.com>
> >
> >         PR rtl-optimization/66782
> >         * lra-int.h (struct lra_insn_recog_data): Add comment about
> >         clobbered hard regs for arg_hard_regs.
> >         * lra.c (lra_set_insn_recog_data): Add clobbered hard regs.
> >         * lra-lives.c (process_bb_lives): Process clobbered hard regs.
> >         Add condition for processing used hard regs.
> >         * lra-constraints.c (update_ebb_live_info, inherit_in_ebb):
> >         Process clobbered hard regs.
> 
> I would like to nominate this patch for gcc-5.2 release. According to
> downstream bugreport [1], gcc-5.1 is unusable for 64-bit wine:
> 
> "Breaks all of wine, no easy workaround -> blocker."
> 
> Due to severity of this bug, and importance of Wine, I'd like to
> postpone the 5.2 release for a week, so this bug gets some testing in
> the mainline, before it is backported to gcc-5 branch
> 
> [1] https://bugs.winehq.org/show_bug.cgi?id=38653

Hm.  I'd rather burn this with a RC2 released soon or defer it to
GCC 5.3.  The patch looks kind-of straight-forward, likely not
affecting anything else (to my naiive eyes...).

So - please get it committed to the GCC 5 branch as soon as possible.
A GCC 5.2 RC2 will be done on Monday latest then (possibly during the
weekend if I find the time to do it).

Note this opens the window for other important wrong-code fixes - please
CC me on any you'd like to propose for GCC 5.2 and wait for my
explicit approval.

Thanks,
Richard.

Re: Proposal to postpone release of 5.2 for a week

[Kaz Kojima]

Richard Biener <rguenther@suse.de> wrote:
> Note this opens the window for other important wrong-code fixes - please
> CC me on any you'd like to propose for GCC 5.2 and wait for my
> explicit approval.

Can I backport the patch in

[SH] Fix PR target/66780
https://gcc.gnu.org/ml/gcc-patches/2015-07/msg00472.html

to gcc-5.2?  It's a few lines change for a SH specific wrong code bug
with -fstack-protector which is disastrous for Debian SH folks who use
that option heavily in their packages.

Regards,
	kaz

Re: Proposal to postpone release of 5.2 for a week

[Richard Biener]

On Fri, 10 Jul 2015, Kaz Kojima wrote:

> Richard Biener <rguenther@suse.de> wrote:
> > Note this opens the window for other important wrong-code fixes - please
> > CC me on any you'd like to propose for GCC 5.2 and wait for my
> > explicit approval.
> 
> Can I backport the patch in
> 
> [SH] Fix PR target/66780
> https://gcc.gnu.org/ml/gcc-patches/2015-07/msg00472.html
> 
> to gcc-5.2?  It's a few lines change for a SH specific wrong code bug
> with -fstack-protector which is disastrous for Debian SH folks who use
> that option heavily in their packages.

Yes.

Thanks,
Richard.

> Regards,
> 	kaz
> 
> 

-- 
Richard Biener <rguenther@suse.de>
SUSE LINUX GmbH, GF: Felix Imendoerffer, Jane Smithard, Dilip Upmanyu, Graham Norton, HRB 21284 (AG Nuernberg)

Re: Proposal to postpone release of 5.2 for a week

[Kaz Kojima]

Richard Biener <rguenther@suse.de> wrote:
>> Can I backport the patch in
>> 
>> [SH] Fix PR target/66780
>> https://gcc.gnu.org/ml/gcc-patches/2015-07/msg00472.html
>> 
>> to gcc-5.2?  It's a few lines change for a SH specific wrong code bug
>> with -fstack-protector which is disastrous for Debian SH folks who use
>> that option heavily in their packages.
> 
> Yes.

Thanks!  I've just committed it as revision 225660.

Regards,
	kaz

Re: Proposal to postpone release of 5.2 for a week [Was: Re: patch to fix PR66782]

[Vladimir Makarov]

On 07/10/2015 04:09 AM, Richard Biener wrote:
> On Thu, 9 Jul 2015, Uros Bizjak wrote:
>
>> Hello!
>>
>>> The patch was bootstrapped and tested on x86/x86-64.
>>>
>>> Committed as rev. 225618.
>>>
>>> 2015-07-09  Vladimir Makarov  <vmakarov@redhat.com>
>>>
>>>          PR rtl-optimization/66782
>>>          * lra-int.h (struct lra_insn_recog_data): Add comment about
>>>          clobbered hard regs for arg_hard_regs.
>>>          * lra.c (lra_set_insn_recog_data): Add clobbered hard regs.
>>>          * lra-lives.c (process_bb_lives): Process clobbered hard regs.
>>>          Add condition for processing used hard regs.
>>>          * lra-constraints.c (update_ebb_live_info, inherit_in_ebb):
>>>          Process clobbered hard regs.
>> I would like to nominate this patch for gcc-5.2 release. According to
>> downstream bugreport [1], gcc-5.1 is unusable for 64-bit wine:
>>
>> "Breaks all of wine, no easy workaround -> blocker."
>>
>> Due to severity of this bug, and importance of Wine, I'd like to
>> postpone the 5.2 release for a week, so this bug gets some testing in
>> the mainline, before it is backported to gcc-5 branch
>>
>> [1] https://bugs.winehq.org/show_bug.cgi?id=38653
> Hm.  I'd rather burn this with a RC2 released soon or defer it to
> GCC 5.3.  The patch looks kind-of straight-forward, likely not
> affecting anything else (to my naiive eyes...).
>
> So - please get it committed to the GCC 5 branch as soon as possible.
> A GCC 5.2 RC2 will be done on Monday latest then (possibly during the
> weekend if I find the time to do it).
>
> Note this opens the window for other important wrong-code fixes - please
> CC me on any you'd like to propose for GCC 5.2 and wait for my
> explicit approval.
>
>
Thanks, Richard.  I believe the patch is safe.  So I've backported the 
patch to the branch as rev. 225674.  I successfully bootstrapped and 
tested it on x86-64.