From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 76471 invoked by alias); 10 Jul 2015 23:38:20 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 76461 invoked by uid 89); 10 Jul 2015 23:38:19 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 10 Jul 2015 23:38:18 +0000 Received: from nat-ies.mentorg.com ([192.94.31.2] helo=SVR-IES-FEM-01.mgc.mentorg.com) by relay1.mentorg.com with esmtp id 1ZDhry-0004NC-6k from Bernd_Schmidt@mentor.com ; Fri, 10 Jul 2015 16:38:14 -0700 Received: from [127.0.0.1] (137.202.0.76) by SVR-IES-FEM-01.mgc.mentorg.com (137.202.0.104) with Microsoft SMTP Server id 14.3.224.2; Sat, 11 Jul 2015 00:38:12 +0100 Message-ID: <55A05756.4060601@codesourcery.com> Date: Fri, 10 Jul 2015 23:38:00 -0000 From: Bernd Schmidt User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Nathan Sidwell CC: GCC Patches Subject: Re: [nvptx] mkoffload cleanup References: <55A04CE9.3000301@acm.org> In-Reply-To: <55A04CE9.3000301@acm.org> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2015-07/txt/msg00939.txt.bz2 On 07/11/2015 12:53 AM, Nathan Sidwell wrote: > I'mm working through the mkoffload machinery. mkoffload.c emits a C > file, and the quoting in the source is quite confusing. This patch > introduces a quoting macro 'Q' that allows one to write raw C to be > stringized and written out. > > ok? (more cleanups to follow) The quoting is fairly standard and used throughout gcc, and I guess I'm kind of used to seeing it - the patch would make things inconsistent with everything else. It's also nonobvious and probably unintentional that indentation and linebreaks get lost in some places in the output when the patch is applied - the following is emitted as a single line: extern void *__OFFLOAD_TABLE__[]; static __attribute__((constructor)) void init (void) { GOMP_offload_register (__OFFLOAD_TABLE__, 5, &target_data); } So, I'm sorry - not a fan of this. Bernd