From: Jeff Law <law@redhat.com>
To: Andrew MacLeod <amacleod@redhat.com>,
gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [patch] bit of cleanup to graphite files
Date: Sat, 11 Jul 2015 05:49:00 -0000 [thread overview]
Message-ID: <55A0AE70.90608@redhat.com> (raw)
In-Reply-To: <55A02F6A.1030602@redhat.com>
On 07/10/2015 02:47 PM, Andrew MacLeod wrote:
> I noticed a few annoying bits around the graphite files that I decided
> to cleanup.
>
> - omega.h shouldn't include "config.h". including params.h is fine
> since it is needed, but it should be within the #ifndef GCC_OMEGA_H guard.
> - sese.h is required for compilation of graphite-poly.h, and basically
> isn't used anywhere else (except sese.c) , so simply include it in
> graphite-poly.h.
> - I adjusted the rest of the graphite files . All but graphite.c guard
> the enter contents of the file with HAVE_isl, but they all include a ton
> of GCC includes outside the guard. I moved them inside the guard and
> ran include reduction on them all to remove the unneeded headers.
> - graphite.c was similar, except it has a small hunk of code which is
> compiled when HAVE_isl is false. I manually adjusted those includes to
> be minimal, and ran include reduction on the rest.
>
> I bootstrapped with HAVE_isl defined and also with it not defined on
> x86_64-unknown-linux-gnu. I ran it with no regressions with HAVE_isl
> defined.
>
> OK for trunk?
OK.
jeff
prev parent reply other threads:[~2015-07-11 5:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-10 20:47 Andrew MacLeod
2015-07-11 5:49 ` Jeff Law [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55A0AE70.90608@redhat.com \
--to=law@redhat.com \
--cc=amacleod@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).