From: Nathan Sidwell <nathan@acm.org>
To: Ilya Verbin <iverbin@gmail.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: GOMP_offload_register
Date: Mon, 13 Jul 2015 13:59:00 -0000 [thread overview]
Message-ID: <55A3C429.9060206@acm.org> (raw)
In-Reply-To: <20150713134924.GB56059@msticlxl57.ims.intel.com>
On 07/13/15 09:49, Ilya Verbin wrote:
> On Mon, Jul 13, 2015 at 09:42:50 -0400, Nathan Sidwell wrote:
>> GOMP_offload_register's target data argument is 'void *'. Is there
>> any reason it shouldn't be 'const void *'? It would seem to me that
>> that would be better?
>>
>> (a cursory look at i386/intelmic-mkoffload.c suggests a lack of
>> consts in the variable decls there. ptx suffers the same problem)
>
> I can't remember any reason, so I agree that const is better (if this works :)
Ok, I'll work in that direction.
(my thought was that for targets where their is mutable data in there, they
should insert the appropriate const-removing casts)
nathan
prev parent reply other threads:[~2015-07-13 13:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-13 13:42 GOMP_offload_register Nathan Sidwell
2015-07-13 13:49 ` GOMP_offload_register Ilya Verbin
2015-07-13 13:59 ` Nathan Sidwell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55A3C429.9060206@acm.org \
--to=nathan@acm.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=iverbin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).