[PATCH][ARM][testsuite] Fix FAIL: gcc.target/arm/macro_defs0.c and macro_defs1.c when -marm forced

[PATCH][ARM][testsuite] Fix FAIL: gcc.target/arm/macro_defs0.c and macro_defs1.c when -marm forced

[Mantas Mikaitis]

[-- Attachment #1: Type: text/plain, Size: 590 bytes --]

Hello,

Tests gcc.target/arm/macro_defs0.c and gcc.target/arm/macro_defs1.c fail 
in multilib which forces -marm as pointed out in this message: 
https://gcc.gnu.org/ml/gcc-patches/2015-02/msg00483.html .

This patch will cause these tests to be classified as unsupported rather 
than FAIL.

Ok for trunk?

Kind regards,
Mantas M.

2015-03-05  Mantas Mikaitis  <mantas.mikaitis@arm.com>

     * gcc.target/arm/macro_defs0.c: added directive to skip
     test if -marm is present.
     * gcc.target/arm/macro_defs1.c: added directive to skip
     test if -marm is present.

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: macro_defs_marm_not_supported.patch --]
[-- Type: text/x-patch; name=macro_defs_marm_not_supported.patch, Size: 1229 bytes --]

diff --git a/gcc/testsuite/gcc.target/arm/macro_defs0.c b/gcc/testsuite/gcc.target/arm/macro_defs0.c
index 962ff03..684d49f 100644
--- a/gcc/testsuite/gcc.target/arm/macro_defs0.c
+++ b/gcc/testsuite/gcc.target/arm/macro_defs0.c
@@ -1,6 +1,7 @@
 /* { dg-do compile } */
 /* { dg-skip-if "avoid conflicting multilib options" { *-*-* } { "-march=*" } { "-march=armv7-m" } } */
 /* { dg-skip-if "avoid conflicting multilib options" { *-*-* } { "-mfloat-abi=*" } { "-mfloat-abi=soft" } } */
+/* { dg-skip-if "avoid conflicting multilib options" { *-*-* } { "-marm" } { "" } } */
 /* { dg-options "-march=armv7-m -mcpu=cortex-m3 -mfloat-abi=soft -mthumb" } */
 
 #ifdef __ARM_FP
diff --git a/gcc/testsuite/gcc.target/arm/macro_defs1.c b/gcc/testsuite/gcc.target/arm/macro_defs1.c
index d5423c7..4cc9ae6 100644
--- a/gcc/testsuite/gcc.target/arm/macro_defs1.c
+++ b/gcc/testsuite/gcc.target/arm/macro_defs1.c
@@ -1,5 +1,6 @@
 /* { dg-do compile } */
 /* { dg-skip-if "avoid conflicting multilib options" { *-*-* } { "-march=*" } { "-march=armv6-m" } } */
+/* { dg-skip-if "avoid conflicting multilib options" { *-*-* } { "-marm" } { "" } } */
 /* { dg-options "-march=armv6-m -mthumb" } */
 
 #ifdef __ARM_NEON_FP

Ping: [PATCH][ARM][testsuite] Fix FAIL: gcc.target/arm/macro_defs0.c and macro_defs1.c when -marm forced

[Mantas Mikaitis]

Pinging this patch.

Thank you,
- Mantas

On 05/03/15 10:14, Mantas Mikaitis wrote:
> Hello,
>
> Tests gcc.target/arm/macro_defs0.c and gcc.target/arm/macro_defs1.c fail
> in multilib which forces -marm as pointed out in this message:
> https://gcc.gnu.org/ml/gcc-patches/2015-02/msg00483.html .
>
> This patch will cause these tests to be classified as unsupported rather
> than FAIL.
>
> Ok for trunk?
>
> Kind regards,
> Mantas M.
>
> 2015-03-05  Mantas Mikaitis  <mantas.mikaitis@arm.com>
>
>       * gcc.target/arm/macro_defs0.c: added directive to skip
>       test if -marm is present.
>       * gcc.target/arm/macro_defs1.c: added directive to skip
>       test if -marm is present.

Re: [PATCH][ARM][testsuite] Fix FAIL: gcc.target/arm/macro_defs0.c and macro_defs1.c when -marm forced

[Kyrill Tkachov]

Hi Mantas,

On 05/03/15 10:14, Mantas Mikaitis wrote:
> Hello,
>
> Tests gcc.target/arm/macro_defs0.c and gcc.target/arm/macro_defs1.c fail
> in multilib which forces -marm as pointed out in this message:
> https://gcc.gnu.org/ml/gcc-patches/2015-02/msg00483.html .
>
> This patch will cause these tests to be classified as unsupported rather
> than FAIL.
>
> Ok for trunk?
>
> Kind regards,
> Mantas M.
>
> 2015-03-05  Mantas Mikaitis  <mantas.mikaitis@arm.com>
>
>       * gcc.target/arm/macro_defs0.c: added directive to skip
>       test if -marm is present.
>       * gcc.target/arm/macro_defs1.c: added directive to skip
>       test if -marm is present.

Ok for trunk, sorry for the delay.
I have committed this to trunk for you as r225742 with the
ChangeLog entry:

2015-07-13  Mantas Mikaitis  <mantas.mikaitis@arm.com>

     * gcc.target/arm/macro_defs0.c: Add directive to skip
     test if -marm is present.
     * gcc.target/arm/macro_defs1.c: Likewise.

Re: [PATCH][ARM][testsuite] Fix FAIL: gcc.target/arm/macro_defs0.c and macro_defs1.c when -marm forced

[Kyrill Tkachov]

On 13/07/15 17:01, Kyrill Tkachov wrote:
> Hi Mantas,
>
> On 05/03/15 10:14, Mantas Mikaitis wrote:
>> Hello,
>>
>> Tests gcc.target/arm/macro_defs0.c and gcc.target/arm/macro_defs1.c fail
>> in multilib which forces -marm as pointed out in this message:
>> https://gcc.gnu.org/ml/gcc-patches/2015-02/msg00483.html .
>>
>> This patch will cause these tests to be classified as unsupported rather
>> than FAIL.
>>
>> Ok for trunk?
>>
>> Kind regards,
>> Mantas M.
>>
>> 2015-03-05  Mantas Mikaitis  <mantas.mikaitis@arm.com>
>>
>>        * gcc.target/arm/macro_defs0.c: added directive to skip
>>        test if -marm is present.
>>        * gcc.target/arm/macro_defs1.c: added directive to skip
>>        test if -marm is present.
> Ok for trunk, sorry for the delay.
> I have committed this to trunk for you as r225742 with the
> ChangeLog entry:
>
> 2015-07-13  Mantas Mikaitis  <mantas.mikaitis@arm.com>
>
>       * gcc.target/arm/macro_defs0.c: Add directive to skip
>       test if -marm is present.
>       * gcc.target/arm/macro_defs1.c: Likewise.
>

Hi all,

I've backported this patch to the GCC 5 and 4.9 branches as well.

Thanks,
Kyrill