From: Jeff Law <law@redhat.com>
To: Uros Bizjak <ubizjak@gmail.com>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH 1/2, rtl-optimization]: Fix PR 58066, __tls_get_addr is called with misaligned stack on x86-64
Date: Tue, 14 Jul 2015 04:46:00 -0000 [thread overview]
Message-ID: <55A49412.8060007@redhat.com> (raw)
In-Reply-To: <CAFULd4Y+XxWA5WEgLvYZd5KqDp732k2sbKbA+haOsy=U6gw8+g@mail.gmail.com>
On 07/13/2015 11:03 AM, Uros Bizjak wrote:
> This is rtl-optimization part of a two-part patch series.
>
> As discussed in the PR, we have to prcompute register parameters
> before stack alignment is performed, otherwise eventual call to
> __tls_get_addr can be called with unaligned stack. When compiling the
> testcase from the PR, anti_adjust_stack is called just before
> precompute starts expanding function parameters.
>
> The solution is to move precomputation before stack pointer is adjusted.
>
> 2015-07-13 Uros Bizjak <ubizjak@gmail.com>
>
> PR rtl-optimization/58066
> * calls.c (expand_call): Precompute register parameters before stack
> alignment is performed.
>
> Patch was bootstrapped and regression tested on x86_64-linux-gnu
> {,-m32} for all default languages, obj-c++ and go.
>
> OK for mainline?
OK once a comment is added indicating why we have to precompute before
the anti-adjust-stack.
jeff
next prev parent reply other threads:[~2015-07-14 4:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-13 17:03 Uros Bizjak
2015-07-14 4:46 ` Jeff Law [this message]
2015-07-15 8:03 ` Uros Bizjak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55A49412.8060007@redhat.com \
--to=law@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=ubizjak@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).