From: Basile Starynkevitch <basile@starynkevitch.net>
To: David Malcolm <dmalcolm@redhat.com>
Cc: gcc-patches@gcc.gnu.org, jit@gcc.gnu.org
Subject: Re: PATCH trunk GCCJIT: adding gcc_jit_context_new_rvalue_from_long_long, etc...
Date: Wed, 15 Jul 2015 19:37:00 -0000 [thread overview]
Message-ID: <55A6B139.7050708@starynkevitch.net> (raw)
In-Reply-To: <1436986339.830.59.camel@surprise>
On 07/15/2015 20:52, David Malcolm wrote:
> On Wed, 2015-07-15 at 20:19 +0200, Basile Starynkevitch wrote:
>> Hello All and David Malcolm
>>
>> The attached patch (relative to trunk r224842) is adding
>> gcc_jit_context_new_rvalue_from_long_long and similar functions to
>> GCCJIT.
> Does this actually link and run? This appears to be missing some
> implementations of the template specializations in jit/jit-recording.c
> for the new specializations of new_rvalue_from_const. If these are
> missing, I'd expect to see a linker error at run-time when attempting
> to run client code that links against such a libgccjit.so.
It does bootstrap (in the GCC sense). I suspect that C++ integral
promotion or casting rules are enough to have something being linked,
but probably not what is really needed. And I'm testing that on
x86-64/Linux where the patch is almost useless.
Thanks for your other comments. I'm trying to understand them and I am
working on that.
Cheers
--
Basile STARYNKEVITCH http://starynkevitch.net/Basile/
email: basile<at>starynkevitch<dot>net mobile: +33 6 8501 2359
8, rue de la Faiencerie, 92340 Bourg La Reine, France
*** opinions {are only mine, sont seulement les miennes} ***
next prev parent reply other threads:[~2015-07-15 19:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-15 18:43 Basile Starynkevitch
2015-07-15 19:04 ` David Malcolm
2015-07-15 19:37 ` Basile Starynkevitch [this message]
2015-07-15 19:37 ` David Malcolm
2015-07-16 9:25 ` PATCH (v2) " Basile Starynkevitch
2015-07-17 13:50 ` David Malcolm
2015-07-17 14:19 ` David Malcolm
2015-07-15 19:56 ` PATCH " Basile Starynkevitch
2015-07-15 21:37 ` David Malcolm
2015-07-16 20:08 ` [PATCH, committed] jit: Add guide for submitting patches to jit docs David Malcolm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55A6B139.7050708@starynkevitch.net \
--to=basile@starynkevitch.net \
--cc=dmalcolm@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jit@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).