[PATCH] fix PR ada/42978

[PATCH] fix PR ada/42978

[Simon Wright]

[-- Attachment #1: Type: text/plain, Size: 310 bytes --]

Gnatmake doesn't report the options it passes to ranlib.

Patch tested in gcc version 4.5.0 20100131 (experimental) [trunk revision 156398] (GCC) (x64_64-apple-darwin10.2.0).

OK for trunk?

2010-02-07  Simon Wright  <simon@pushface.org>

	PR ada/42978
	* mlib-utl.adb (Ar): Output ranlib options if verbose.


[-- Attachment #2: gcc-ada-mlib-utl.adb.diff --]
[-- Type: application/octet-stream, Size: 564 bytes --]

Index: gcc/ada/mlib-utl.adb
===================================================================
--- gcc/ada/mlib-utl.adb	(revision 156574)
+++ gcc/ada/mlib-utl.adb	(working copy)
@@ -284,6 +284,10 @@
          if not Opt.Quiet_Output then
             Write_Str  (Ranlib_Name.all);
             Write_Char (' ');
+            for I in Ranlib_Options.all'Range loop
+               Write_Str  (Ranlib_Options.all (I).all);
+               Write_Char (' ');
+            end loop;
             Write_Line (Arguments (Ar_Options'Length + 1).all);
          end if;
 

Re: [PATCH] fix PR ada/42978

[Arnaud Charlet]

> Patch tested in gcc version 4.5.0 20100131 (experimental) [trunk revision 156398] (GCC) (x64_64-apple-darwin10.2.0).
> 
> OK for trunk?

+            for I in Ranlib_Options.all'Range loop

we never use I (can be confused with 1). You can use J instead.

Also, we use Ranlib_Options'Range, without the explicit .all

+               Write_Str  (Ranlib_Options.all (I).all);

Same here.

Arno

Re: [PATCH] fix PR ada/42978

[Simon Wright]

[-- Attachment #1: Type: text/plain, Size: 681 bytes --]

On 7 Feb 2010, at 19:39, Arnaud Charlet wrote:

>> Patch tested in gcc version 4.5.0 20100131 (experimental) [trunk revision 156398] (GCC) (x64_64-apple-darwin10.2.0).
>> 
>> OK for trunk?
> 
> +            for I in Ranlib_Options.all'Range loop
> 
> we never use I (can be confused with 1). You can use J instead.
> 
> Also, we use Ranlib_Options'Range, without the explicit .all
> 
> +               Write_Str  (Ranlib_Options.all (I).all);
> 
> Same here.

OK, second try.

Tested on gcc version 4.5.0 20100207 (experimental) [trunk revision 156574] (GCC).

2010-02-07  Simon Wright  <simon@pushface.org>

	PR ada/42978
	* mlib-utl.adb (Ar): Output ranlib options if verbose.



[-- Attachment #2: gcc-ada-mlib-utl.adb.diff --]
[-- Type: application/octet-stream, Size: 581 bytes --]

Index: gcc/ada/mlib-utl.adb
===================================================================
--- gcc/ada/mlib-utl.adb	(revision 156574)
+++ gcc/ada/mlib-utl.adb	(working copy)
@@ -284,6 +284,10 @@ package body MLib.Utl is
          if not Opt.Quiet_Output then
             Write_Str  (Ranlib_Name.all);
             Write_Char (' ');
+            for J in Ranlib_Options'Range loop
+               Write_Str  (Ranlib_Options (J).all);
+               Write_Char (' ');
+            end loop;
             Write_Line (Arguments (Ar_Options'Length + 1).all);
          end if;
 

Re: [PATCH] fix PR ada/42978

[Arnaud Charlet]

> OK, second try.
> 
> Tested on gcc version 4.5.0 20100207 (experimental) [trunk revision 156574] (GCC).
> 
> 2010-02-07  Simon Wright  <simon@pushface.org>
> 
> 	PR ada/42978
> 	* mlib-utl.adb (Ar): Output ranlib options if verbose.

This is OK, thanks.

Re: [PATCH] fix PR ada/42978

[Simon Wright]

[-- Attachment #1: Type: text/plain, Size: 503 bytes --]

On 8 Feb 2010, at 14:18, Arnaud Charlet wrote:

>> OK, second try.
>> 
>> Tested on gcc version 4.5.0 20100207 (experimental) [trunk revision 156574] (GCC).
>> 
>> 2010-02-07  Simon Wright  <simon@pushface.org>
>> 
>> 	PR ada/42978
>> 	* mlib-utl.adb (Ar): Output ranlib options if verbose.
> 
> This is OK, thanks.

Can this be applied, please? The patch still applies at r178911.

2010-02-07  Simon Wright  <simon@pushface.org>

	PR ada/42978
	* mlib-utl.adb (Ar): Output ranlib options if verbose.



[-- Attachment #2: gcc-ada-mlib-utl.adb.diff --]
[-- Type: application/octet-stream, Size: 581 bytes --]

Index: gcc/ada/mlib-utl.adb
===================================================================
--- gcc/ada/mlib-utl.adb	(revision 156574)
+++ gcc/ada/mlib-utl.adb	(working copy)
@@ -284,6 +284,10 @@ package body MLib.Utl is
          if not Opt.Quiet_Output then
             Write_Str  (Ranlib_Name.all);
             Write_Char (' ');
+            for J in Ranlib_Options'Range loop
+               Write_Str  (Ranlib_Options (J).all);
+               Write_Char (' ');
+            end loop;
             Write_Line (Arguments (Ar_Options'Length + 1).all);
          end if;