From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 60325 invoked by alias); 20 Jul 2015 03:18:59 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 60175 invoked by uid 89); 20 Jul 2015 03:18:06 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-pd0-f169.google.com Received: from mail-pd0-f169.google.com (HELO mail-pd0-f169.google.com) (209.85.192.169) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Mon, 20 Jul 2015 03:18:04 +0000 Received: by pdrg1 with SMTP id g1so95114742pdr.2 for ; Sun, 19 Jul 2015 20:18:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type; bh=XSJr9m388vOTLz+qohE3Wh/TP88ZTZqUY/0R7ia/9yc=; b=BbpAI91PZjuL/MibwugknrJdm3yCc3a92/zzvjMIxulHG07XpDvM/q2qWQOzhniHd3 xRtnCQ5Y5TxyhaSg+tdumhinAsZRodObUlNd+8FR4EMpk5uVCeXJfG3TYN3ayEX7FBma PQBNoeVFVp8snCAQqguVDdBtNQhOAWXHqnHjLshCNw1DZYHPPAj+njNAvop820zza4bu arIINRfAirBr5T1IaNh1VrPKTbHuH7pd96RujzZnmJoXvWmaHTwCHy3gNmOcqfGQwLmq nRXac6fPH4pJXTi/ZvnN2WNKrrvkmm5Mu92U6UWAXIlFUag67Ax+JBP55BmwNQDGPBuT FdXg== X-Gm-Message-State: ALoCoQmbqX305UN/kqCRvBsQN/7Qi2XQO+nhwlw3i1/G2zNWQNrY9JRHjqlskCmTvFe2geFDvuWm X-Received: by 10.70.88.226 with SMTP id bj2mr55685918pdb.84.1437362280692; Sun, 19 Jul 2015 20:18:00 -0700 (PDT) Received: from [10.1.1.8] (58-6-183-210.dyn.iinet.net.au. [58.6.183.210]) by smtp.googlemail.com with ESMTPSA id w3sm18676477pdl.45.2015.07.19.20.17.57 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 19 Jul 2015 20:17:58 -0700 (PDT) Message-ID: <55AC685A.8080906@linaro.org> Date: Mon, 20 Jul 2015 07:15:00 -0000 From: Kugan User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Jeff Law , Maxim Kuvyrkov CC: "gcc-patches@gcc.gnu.org" Subject: Re: [PATCH 1/2] Allow REG_EQUAL for ZERO_EXTRACT References: <558FD9D5.9070703@linaro.org> <558FDA78.9030606@linaro.org> <559212EF.7080301@linaro.org> <44190061-8CD0-417F-8592-23EC3C0BB9A3@linaro.org> <5599BAE4.80103@linaro.org> <559AEF4C.6060506@redhat.com> In-Reply-To: <559AEF4C.6060506@redhat.com> Content-Type: multipart/mixed; boundary="------------070900090301020604040107" X-IsSubscribed: yes X-SW-Source: 2015-07/txt/msg01628.txt.bz2 This is a multi-part message in MIME format. --------------070900090301020604040107 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-length: 937 I have made a mistake while addressing the review comments for this patch. Unfortunately, It was not detected in my earlier testing. My sincere graphology for the mistake. I have basically missed the STRICT_LOW_PART check for the first if-check thus the second part (which is the ZERO_EXTRACT part) will never get executed. Attached patch fixes this along with some minor changes. Bootstrapped and regression tested on arm-none-linux (Chromebook) and x86-64-linux-gnu with no new regression along with the ARM ennoblement patch. Also did a complete arm qemu regression testing with Chriophe's scripts with no new regression. (http://people.linaro.org/~christophe.lyon/cross-validation/gcc-test-patches/225987-reg4/report-build-info.html) Is this OK for trunk, Thanks, Kugan gcc/ChangeLog: 2015-07-20 Kugan Vivekanandarajah * cse.c (cse_insn): Fix missing check for STRICT_LOW_PART and minor clean up. --------------070900090301020604040107 Content-Type: text/plain; charset=UTF-8; name="p.txt" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="p.txt" Content-length: 2099 ZGlmZiAtLWdpdCBhL2djYy9jc2UuYyBiL2djYy9jc2UuYwppbmRleCAxYzE0 ZDgzLi45NmFkZjE4IDEwMDY0NAotLS0gYS9nY2MvY3NlLmMKKysrIGIvZ2Nj L2NzZS5jCkBAIC00NTI5LDEwICs0NTI5LDEwIEBAIGNzZV9pbnNuIChydHhf aW5zbiAqaW5zbikKICAgICAgdGhpcyBjYXNlLCBhbmQgaWYgaXQgaXNuJ3Qg c2V0LCB0aGVuIHRoZXJlIHdpbGwgYmUgbm8gZXF1aXZhbGVuY2UKICAgICAg Zm9yIHRoZSBkZXN0aW5hdGlvbi4gICovCiAgIGlmIChuX3NldHMgPT0gMSAm JiBSRUdfTk9URVMgKGluc24pICE9IDAKLSAgICAgICYmICh0ZW0gPSBmaW5k X3JlZ19ub3RlIChpbnNuLCBSRUdfRVFVQUwsIE5VTExfUlRYKSkgIT0gMCkK KyAgICAgICYmICh0ZW0gPSBmaW5kX3JlZ19ub3RlIChpbnNuLCBSRUdfRVFV QUwsIE5VTExfUlRYKSkgIT0gMAorICAgICAgJiYgKCEgcnR4X2VxdWFsX3Ag KFhFWFAgKHRlbSwgMCksIFNFVF9TUkMgKHNldHNbMF0ucnRsKSkpKQogICAg IHsKLSAgICAgIGlmICgoISBydHhfZXF1YWxfcCAoWEVYUCAodGVtLCAwKSwg U0VUX1NSQyAoc2V0c1swXS5ydGwpKSkKLQkgIHx8IEdFVF9DT0RFIChTRVRf REVTVCAoc2V0c1swXS5ydGwpKSA9PSBTVFJJQ1RfTE9XX1BBUlQpCisgICAg ICBpZiAoR0VUX0NPREUgKFNFVF9ERVNUIChzZXRzWzBdLnJ0bCkpID09IFNU UklDVF9MT1dfUEFSVCkKIAlzcmNfZXF2ID0gY29weV9ydHggKFhFWFAgKHRl bSwgMCkpOwogCiAgICAgICAvKiBJZiBERVNUIGlzIG9mIHRoZSBmb3JtIFpF Uk9fRVhUQUNULCBhcyBpbjoKQEAgLTQ1NDQsMTQgKzQ1NDQsMTQgQEAgY3Nl X2luc24gKHJ0eF9pbnNuICppbnNuKQogCSBwb2ludC4gIE5vdGUgdGhhdCB0 aGlzIGlzIGRpZmZlcmVudCBmcm9tIFNSQ19FUVYuIFdlIGNhbiBob3dldmVy CiAJIGNhbGN1bGF0ZSBTUkNfRVFWIHdpdGggdGhlIHBvc2l0aW9uIGFuZCB3 aWR0aCBvZiBaRVJPX0VYVFJBQ1QuICAqLwogICAgICAgZWxzZSBpZiAoR0VU X0NPREUgKFNFVF9ERVNUIChzZXRzWzBdLnJ0bCkpID09IFpFUk9fRVhUUkFD VAotCSAgICAgICAmJiBDT05TVF9JTlRfUCAoc3JjX2VxdikKKwkgICAgICAg JiYgQ09OU1RfSU5UX1AgKFhFWFAgKHRlbSwgMCkpCiAJICAgICAgICYmIENP TlNUX0lOVF9QIChYRVhQIChTRVRfREVTVCAoc2V0c1swXS5ydGwpLCAxKSkK IAkgICAgICAgJiYgQ09OU1RfSU5UX1AgKFhFWFAgKFNFVF9ERVNUIChzZXRz WzBdLnJ0bCksIDIpKSkKIAl7CiAJICBydHggZGVzdF9yZWcgPSBYRVhQIChT RVRfREVTVCAoc2V0c1swXS5ydGwpLCAwKTsKIAkgIHJ0eCB3aWR0aCA9IFhF WFAgKFNFVF9ERVNUIChzZXRzWzBdLnJ0bCksIDEpOwogCSAgcnR4IHBvcyA9 IFhFWFAgKFNFVF9ERVNUIChzZXRzWzBdLnJ0bCksIDIpOwotCSAgSE9TVF9X SURFX0lOVCB2YWwgPSBJTlRWQUwgKHNyY19lcXYpOworCSAgSE9TVF9XSURF X0lOVCB2YWwgPSBJTlRWQUwgKFhFWFAgKHRlbSwgMCkpOwogCSAgSE9TVF9X SURFX0lOVCBtYXNrOwogCSAgdW5zaWduZWQgaW50IHNoaWZ0OwogCSAgaWYg KEJJVFNfQklHX0VORElBTikK --------------070900090301020604040107--