Re: [PATCH][RTL-ifcvt] Make non-conditional execution if-conversion more aggressive

[Kyrill Tkachov <kyrylo.tkachov@arm.com>]

Ping.

https://gcc.gnu.org/ml/gcc-patches/2015-07/msg01047.html

The go testsuite passes for me on x86_64-unknown-linux-gnu for me.
A third data point on testing would be appreciated...

Thanks,
Kyrill

On 13/07/15 15:03, Kyrill Tkachov wrote:
> Hi Bernhard,
>
> On 13/07/15 10:45, Kyrill Tkachov wrote:
>>> PS: no -mbranch-cost and, a tad more seriously, no --param branch-cost either ;)
>>> PPS: attached meant to illustrate comments above. Untested.
>> Thanks a lot! This is all very helpful.
>> I'll respin the patch.
> Here it is. I've expanded the comments in the functions you mentioned,
> moved the tests to gcc.dg and enabled them for aarch64 and x86 and changed
> the types of the costs used to unsigned int.
>
>
> Bootstrapped on aarch64 and x86_64.
> The go testsuite passes on x86_64-unknown-linux-gnu for me...
>
> Thanks,
> Kyrill
>
> 2015-07-13  Kyrylo Tkachov  <kyrylo.tkachov@arm.com>
>
> 	* ifcvt.c (struct noce_if_info): Add then_simple, else_simple,
> 	then_cost, else_cost fields.  Change branch_cost field to unsigned int.
> 	(end_ifcvt_sequence): Call set_used_flags on each insn in the
> 	sequence.
> 	(noce_simple_bbs): New function.
> 	(noce_try_move): Bail if basic blocks are not simple.
> 	(noce_try_store_flag): Likewise.
> 	(noce_try_store_flag_constants): Likewise.
> 	(noce_try_addcc): Likewise.
> 	(noce_try_store_flag_mask): Likewise.
> 	(noce_try_cmove): Likewise.
> 	(noce_try_minmax): Likewise.
> 	(noce_try_abs): Likewise.
> 	(noce_try_sign_mask): Likewise.
> 	(noce_try_bitop): Likewise.
> 	(bbs_ok_for_cmove_arith): New function.
> 	(noce_emit_all_but_last): Likewise.
> 	(noce_emit_insn): Likewise.
> 	(noce_emit_bb): Likewise.
> 	(noce_try_cmove_arith): Handle non-simple basic blocks.
> 	(insn_valid_noce_process_p): New function.
> 	(bb_valid_for_noce_process_p): Likewise.
> 	(noce_process_if_block): Allow non-simple basic blocks
> 	where appropriate.
>
>
> 2015-07-13  Kyrylo Tkachov  <kyrylo.tkachov@arm.com>
>
> 	* gcc.dg/ifcvt-1.c: New test.
> 	* gcc.dg/ifcvt-2.c: Likewise.
> 	* gcc.dg/ifcvt-3.c: Likewise.
>
>
>
>
>> Thanks,
>> Kyrill
>>
>>
>>> cheers,