From: Bernd Schmidt <bernds@codesourcery.com>
To: Nathan Sidwell <nathan@acm.org>, <gcc-patches@gnu.org>
Subject: Re: [gomp4] New nvptx pattern and internal builtin
Date: Mon, 20 Jul 2015 14:10:00 -0000 [thread overview]
Message-ID: <55ACF9B0.1000205@codesourcery.com> (raw)
In-Reply-To: <55ACF556.5000306@acm.org>
On 07/20/2015 03:19 PM, Nathan Sidwell wrote:
> I was looking at adding another target builtin, and found this code
> rather convoluted. It seemed to have been cloned from somewhere more
> complicated -- for instance, nvptx_expand_binop_builtin's comment
> discusses a MACFLAG argument, which is nowhere to be seen.
Okay, I admit to tuning out comments for code that I know, and I didn't
notice that one. As for being convoluted - this is pretty much the
standard structure for the machine specific builtins which is used in a
lot of ports.
> I ended up reimplementing using a single array describing the builtins
> and allowing direct indexing using the builtin number, rather than
> iteration when expanding.
If you really want to, that's fine, but note the point about consistency
with other ports.
Bernd
prev parent reply other threads:[~2015-07-20 13:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-17 15:44 Bernd Schmidt
2015-07-20 13:45 ` Nathan Sidwell
2015-07-20 14:10 ` Bernd Schmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55ACF9B0.1000205@codesourcery.com \
--to=bernds@codesourcery.com \
--cc=gcc-patches@gnu.org \
--cc=nathan@acm.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).