From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 125836 invoked by alias); 20 Jul 2015 13:38:16 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 125823 invoked by uid 89); 20 Jul 2015 13:38:16 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: fencepost.gnu.org Received: from fencepost.gnu.org (HELO fencepost.gnu.org) (208.118.235.10) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Mon, 20 Jul 2015 13:38:15 +0000 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41985) by fencepost.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ZHBGm-0007xJ-IP for gcc-patches@gnu.org; Mon, 20 Jul 2015 09:38:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZHBGg-0002Ca-BN for gcc-patches@gnu.org; Mon, 20 Jul 2015 09:38:12 -0400 Received: from relay1.mentorg.com ([192.94.38.131]:45818) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZHBGg-00024w-6a for gcc-patches@gnu.org; Mon, 20 Jul 2015 09:38:06 -0400 Received: from nat-ies.mentorg.com ([192.94.31.2] helo=SVR-IES-FEM-01.mgc.mentorg.com) by relay1.mentorg.com with esmtp id 1ZHBGb-00020X-Oc from Bernd_Schmidt@mentor.com ; Mon, 20 Jul 2015 06:38:01 -0700 Received: from [127.0.0.1] (137.202.0.76) by SVR-IES-FEM-01.mgc.mentorg.com (137.202.0.104) with Microsoft SMTP Server id 14.3.224.2; Mon, 20 Jul 2015 14:37:58 +0100 Message-ID: <55ACF9B0.1000205@codesourcery.com> Date: Mon, 20 Jul 2015 14:10:00 -0000 From: Bernd Schmidt User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Nathan Sidwell , Subject: Re: [gomp4] New nvptx pattern and internal builtin References: <55A92142.6050008@codesourcery.com> <55ACF556.5000306@acm.org> In-Reply-To: <55ACF556.5000306@acm.org> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: Windows NT kernel [generic] [fuzzy] X-Received-From: 192.94.38.131 X-SW-Source: 2015-07/txt/msg01648.txt.bz2 On 07/20/2015 03:19 PM, Nathan Sidwell wrote: > I was looking at adding another target builtin, and found this code > rather convoluted. It seemed to have been cloned from somewhere more > complicated -- for instance, nvptx_expand_binop_builtin's comment > discusses a MACFLAG argument, which is nowhere to be seen. Okay, I admit to tuning out comments for code that I know, and I didn't notice that one. As for being convoluted - this is pretty much the standard structure for the machine specific builtins which is used in a lot of ports. > I ended up reimplementing using a single array describing the builtins > and allowing direct indexing using the builtin number, rather than > iteration when expanding. If you really want to, that's fine, but note the point about consistency with other ports. Bernd