From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 113435 invoked by alias); 20 Jul 2015 21:55:44 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 113359 invoked by uid 89); 20 Jul 2015 21:55:43 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: cc-smtpout2.netcologne.de Received: from cc-smtpout2.netcologne.de (HELO cc-smtpout2.netcologne.de) (89.1.8.212) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 20 Jul 2015 21:55:42 +0000 Received: from cc-smtpin3.netcologne.de (cc-smtpin3.netcologne.de [89.1.8.203]) by cc-smtpout2.netcologne.de (Postfix) with ESMTP id 744DB11FE0; Mon, 20 Jul 2015 23:55:37 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by cc-smtpin3.netcologne.de (Postfix) with ESMTP id 6A22A11DF3; Mon, 20 Jul 2015 23:55:37 +0200 (CEST) Received: from [78.35.181.129] (helo=cc-smtpin3.netcologne.de) by localhost with ESMTP (eXpurgate 4.0.9) (envelope-from ) id 55ad6e59-1d75-7f0000012729-7f000001947e-1 for ; Mon, 20 Jul 2015 23:55:37 +0200 Received: from [192.168.178.20] (xdsl-78-35-181-129.netcologne.de [78.35.181.129]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by cc-smtpin3.netcologne.de (Postfix) with ESMTPSA; Mon, 20 Jul 2015 23:55:32 +0200 (CEST) Subject: Re: [Patch, fortran] PR 37131, inline matmul To: Thomas Schwinge , Mikael Morin , Bernd Schmidt References: <55486270.8010909@netcologne.de> <5548BE61.1090506@sfr.fr> <554A78F7.5010300@netcologne.de> <87vbdnzvd4.fsf@kepler.schwinge.homeip.net> Cc: gcc-patches , "fortran@gcc.gnu.org" From: Thomas Koenig Message-ID: <55AD6E53.90800@netcologne.de> Date: Mon, 20 Jul 2015 23:21:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <87vbdnzvd4.fsf@kepler.schwinge.homeip.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2015-07/txt/msg01700.txt.bz2 Hi, I'm back from holiday, so I can finally reply. Am 13.07.2015 um 21:54 schrieb Thomas Schwinge: > --- gcc/fortran/iresolve.c > +++ gcc/fortran/iresolve.c > @@ -2207,6 +2207,9 @@ gfc_resolve_fe_runtime_error (gfc_code *c) > a->name = "%VAL"; > > c->resolved_sym = gfc_get_intrinsic_sub_symbol (name); > + //TODO > + extern tree gfor_fndecl_runtime_error; > + c->resolved_sym->backend_decl = gfor_fndecl_runtime_error; > } This patch actually works quite well. I cannot check the varargs part on x86_64, but the non-return part is OK. Obviously, the backend decl for runtime_error needs to be set. The question is where to put this. iresolve.c seems conceptually wrong, but I cannot find a clean place to put this in trans-*, without special casing in strange places. So, what is the general optionion? Do something in this place which is essentially this patch (plus a GTY in the prototype)? Regards Thomas