From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16295 invoked by alias); 21 Jul 2015 13:25:39 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 16064 invoked by uid 89); 21 Jul 2015 13:25:38 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-qk0-f169.google.com Received: from mail-qk0-f169.google.com (HELO mail-qk0-f169.google.com) (209.85.220.169) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Tue, 21 Jul 2015 13:25:37 +0000 Received: by qkfc129 with SMTP id c129so89579436qkf.1 for ; Tue, 21 Jul 2015 06:25:35 -0700 (PDT) X-Received: by 10.140.84.104 with SMTP id k95mr54820421qgd.45.1437485135037; Tue, 21 Jul 2015 06:25:35 -0700 (PDT) Received: from ?IPv6:2601:181:c000:c497:a2a8:cdff:fe3e:b48? ([2601:181:c000:c497:a2a8:cdff:fe3e:b48]) by smtp.googlemail.com with ESMTPSA id f3sm12647479qhc.22.2015.07.21.06.25.34 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 21 Jul 2015 06:25:34 -0700 (PDT) Subject: Re: fix gomp offload routine unloading To: Ilya Verbin References: <55AD7F87.6020204@acm.org> <20150721095127.GG1780@tucnak.redhat.com> <55AE37ED.60900@acm.org> <20150721132047.GB350@msticlxl57.ims.intel.com> Cc: Jakub Jelinek , Thomas Schwinge , GCC Patches From: Nathan Sidwell Message-ID: <55AE484D.3000100@acm.org> Date: Tue, 21 Jul 2015 13:39:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <20150721132047.GB350@msticlxl57.ims.intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2015-07/txt/msg01753.txt.bz2 On 07/21/15 09:20, Ilya Verbin wrote: > On Tue, Jul 21, 2015 at 08:15:41 -0400, Nathan Sidwell wrote: >> On 07/21/15 05:51, Jakub Jelinek wrote: >>> On Mon, Jul 20, 2015 at 07:08:55PM -0400, Nathan Sidwell wrote: >>>> 2015-07-20 Nathan Sidwell >>>> >>>> libgomp/ >>>> * target.c (gomp_offload_image_to_device): Rename to ... >>>> (gomp_load_image_to_device): ... here. >>>> (GOMP_offload_register): Adjust call. >>>> (gomp_init_device): Likewise. >>>> (gomp_unload_image_from_device): New. Broken out of ... >>>> (GOMP_offload_unregister): ... here. Call it. >>>> (gomp_unload_device): New. >>>> * libgomp.h (gomp_unload_device): Declare. >>>> * oacc-init.c (acc_shutdown_1): Unload from device before deleting >>>> mem maps. >>>> >>>> gcc/ >>>> * config/nvptx/mkoffload.c (process): Add destructor call. >>> >>> Ok if also tested on Intel MIC, with a few changes: >> >> Ilya, are you able to test Intel MIC for me? > > I don't see any regressions on MIC. thanks!