public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* [doc patch] Rename "Language Independent Options" @node in invoke.texi
@ 2015-07-21 12:54 Jonathan Wakely
  2015-07-21 15:37 ` Sandra Loosemore
  0 siblings, 1 reply; 4+ messages in thread
From: Jonathan Wakely @ 2015-07-21 12:54 UTC (permalink / raw)
  To: gcc-patches; +Cc: Gerald Pfeifer, Sandra Loosemore

[-- Attachment #1: Type: text/plain, Size: 1268 bytes --]

This texinfo @node seems misnamed:
https://gcc.gnu.org/onlinedocs/gcc/Language-Independent-Options.html#Language-Independent-Options

It should be something like "Diagnostic Message Formatting Options"
not "Language Independent Options".

The misnomer makes the TOC and navbar confusing and seems to suggest
that warning and debuging options are not language independent, since
they're not part of that node. See
https://gcc.gnu.org/onlinedocs/gcc/Invoking-GCC.html#Invoking-GCC
which has:

* Language Independent Options: Controlling how diagnostics should be formatted.
* Warning Options: How picky should the compiler be?
* Debugging Options: Symbol tables, measurements, and debugging dumps.
* Optimize Options: How much optimization? 

The title of the first entry is completely unrelated to its
description.

An alternative fix would be to keep a "Language Independent Options"
node but nest "Diagnostic Message Formatting Options", "Warning
Options", "Debugging Options" and "Optimize Options" as sub-sections
of it. The downside of that is that it would be harder to find those
sub-sections from the
https://gcc.gnu.org/onlinedocs/gcc/Invoking-GCC.html#Invoking-GCC
node, as you'd have to click through to another page to see the
sub-sections.

OK for trunk?


[-- Attachment #2: patch.txt --]
[-- Type: text/x-patch, Size: 659 bytes --]

commit e3b0376e0440e8af4768b1e1502a57f9ca36be53
Author: Jonathan Wakely <jwakely@redhat.com>
Date:   Tue Jul 21 13:37:16 2015 +0100

    	* doc/invoke.texi (Language Independent Options): Rename node to
    	Diagnostic Message Formatting Options.

diff --git a/gcc/doc/invoke.texi b/gcc/doc/invoke.texi
index 55c2659..9fb2f37 100644
--- a/gcc/doc/invoke.texi
+++ b/gcc/doc/invoke.texi
@@ -3153,7 +3153,7 @@ value, if any.
 
 @end table
 
-@node Language Independent Options
+@node Diagnostic Message Formatting Options
 @section Options to Control Diagnostic Messages Formatting
 @cindex options to control diagnostics formatting
 @cindex diagnostic messages

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [doc patch] Rename "Language Independent Options" @node in invoke.texi
  2015-07-21 12:54 [doc patch] Rename "Language Independent Options" @node in invoke.texi Jonathan Wakely
@ 2015-07-21 15:37 ` Sandra Loosemore
  2015-07-22  0:07   ` Jonathan Wakely
  0 siblings, 1 reply; 4+ messages in thread
From: Sandra Loosemore @ 2015-07-21 15:37 UTC (permalink / raw)
  To: Jonathan Wakely; +Cc: gcc-patches, Gerald Pfeifer

On 07/21/2015 06:52 AM, Jonathan Wakely wrote:
> This texinfo @node seems misnamed:
> https://gcc.gnu.org/onlinedocs/gcc/Language-Independent-Options.html#Language-Independent-Options
>
>
> It should be something like "Diagnostic Message Formatting Options"
> not "Language Independent Options".
>
> The misnomer makes the TOC and navbar confusing and seems to suggest
> that warning and debuging options are not language independent, since
> they're not part of that node. See
> https://gcc.gnu.org/onlinedocs/gcc/Invoking-GCC.html#Invoking-GCC
> which has:
>
> * Language Independent Options: Controlling how diagnostics should be
> formatted.
> * Warning Options: How picky should the compiler be?
> * Debugging Options: Symbol tables, measurements, and debugging dumps.
> * Optimize Options: How much optimization?
> The title of the first entry is completely unrelated to its
> description.
>
> An alternative fix would be to keep a "Language Independent Options"
> node but nest "Diagnostic Message Formatting Options", "Warning
> Options", "Debugging Options" and "Optimize Options" as sub-sections
> of it. The downside of that is that it would be harder to find those
> sub-sections from the
> https://gcc.gnu.org/onlinedocs/gcc/Invoking-GCC.html#Invoking-GCC
> node, as you'd have to click through to another page to see the
> sub-sections.
>
> OK for trunk?

I agree with the proposed renaming of the node, but you need to fix all 
the references to the old name and not just the @node, so no, the patch 
is not OK as-is.

-Sandra

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [doc patch] Rename "Language Independent Options" @node in invoke.texi
  2015-07-21 15:37 ` Sandra Loosemore
@ 2015-07-22  0:07   ` Jonathan Wakely
  2015-07-22  7:08     ` Sandra Loosemore
  0 siblings, 1 reply; 4+ messages in thread
From: Jonathan Wakely @ 2015-07-22  0:07 UTC (permalink / raw)
  To: Sandra Loosemore; +Cc: gcc-patches, Gerald Pfeifer

[-- Attachment #1: Type: text/plain, Size: 1623 bytes --]

On 21/07/15 09:07 -0600, Sandra Loosemore wrote:
>On 07/21/2015 06:52 AM, Jonathan Wakely wrote:
>>This texinfo @node seems misnamed:
>>https://gcc.gnu.org/onlinedocs/gcc/Language-Independent-Options.html#Language-Independent-Options
>>
>>
>>It should be something like "Diagnostic Message Formatting Options"
>>not "Language Independent Options".
>>
>>The misnomer makes the TOC and navbar confusing and seems to suggest
>>that warning and debuging options are not language independent, since
>>they're not part of that node. See
>>https://gcc.gnu.org/onlinedocs/gcc/Invoking-GCC.html#Invoking-GCC
>>which has:
>>
>>* Language Independent Options: Controlling how diagnostics should be
>>formatted.
>>* Warning Options: How picky should the compiler be?
>>* Debugging Options: Symbol tables, measurements, and debugging dumps.
>>* Optimize Options: How much optimization?
>>The title of the first entry is completely unrelated to its
>>description.
>>
>>An alternative fix would be to keep a "Language Independent Options"
>>node but nest "Diagnostic Message Formatting Options", "Warning
>>Options", "Debugging Options" and "Optimize Options" as sub-sections
>>of it. The downside of that is that it would be harder to find those
>>sub-sections from the
>>https://gcc.gnu.org/onlinedocs/gcc/Invoking-GCC.html#Invoking-GCC
>>node, as you'd have to click through to another page to see the
>>sub-sections.
>>
>>OK for trunk?
>
>I agree with the proposed renaming of the node, but you need to fix 
>all the references to the old name and not just the @node, so no, the 
>patch is not OK as-is.

Ah yes, this should do it.



[-- Attachment #2: patch.txt --]
[-- Type: text/x-patch, Size: 1871 bytes --]

commit f8f99bddb9b3f3cb444c219672000e0bebd6f147
Author: Jonathan Wakely <jwakely@redhat.com>
Date:   Tue Jul 21 13:37:16 2015 +0100

    	* doc/invoke.texi (Language Independent Options): Rename node to
    	Diagnostic Message Formatting Options.

diff --git a/gcc/doc/invoke.texi b/gcc/doc/invoke.texi
index 55c2659..c6f84d4 100644
--- a/gcc/doc/invoke.texi
+++ b/gcc/doc/invoke.texi
@@ -125,8 +125,8 @@ only one of these two forms, whichever one is not the default.
 * C++ Dialect Options:: Variations on C++.
 * Objective-C and Objective-C++ Dialect Options:: Variations on Objective-C
                         and Objective-C++.
-* Language Independent Options:: Controlling how diagnostics should be
-                        formatted.
+* Diagnostic Message Formatting Options:: Controlling how diagnostics should
+                        be formatted.
 * Warning Options::     How picky should the compiler be?
 * Debugging Options::   Symbol tables, measurements, and debugging dumps.
 * Optimize Options::    How much optimization?
@@ -228,8 +228,8 @@ Objective-C and Objective-C++ Dialects}.
 -Wstrict-selector-match @gol
 -Wundeclared-selector}
 
-@item Language Independent Options
-@xref{Language Independent Options,,Options to Control Diagnostic Messages Formatting}.
+@item Diagnostic Message Formatting Options
+@xref{Diagnostic Message Formatting Options,,Options to Control Diagnostic Messages Formatting}.
 @gccoptlist{-fmessage-length=@var{n}  @gol
 -fdiagnostics-show-location=@r{[}once@r{|}every-line@r{]}  @gol
 -fdiagnostics-color=@r{[}auto@r{|}never@r{|}always@r{]}  @gol
@@ -3153,7 +3153,7 @@ value, if any.
 
 @end table
 
-@node Language Independent Options
+@node Diagnostic Message Formatting Options
 @section Options to Control Diagnostic Messages Formatting
 @cindex options to control diagnostics formatting
 @cindex diagnostic messages

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [doc patch] Rename "Language Independent Options" @node in invoke.texi
  2015-07-22  0:07   ` Jonathan Wakely
@ 2015-07-22  7:08     ` Sandra Loosemore
  0 siblings, 0 replies; 4+ messages in thread
From: Sandra Loosemore @ 2015-07-22  7:08 UTC (permalink / raw)
  To: Jonathan Wakely; +Cc: gcc-patches, Gerald Pfeifer

On 07/21/2015 04:55 PM, Jonathan Wakely wrote:
> On 21/07/15 09:07 -0600, Sandra Loosemore wrote:
>> On 07/21/2015 06:52 AM, Jonathan Wakely wrote:
>>> This texinfo @node seems misnamed:
>>> https://gcc.gnu.org/onlinedocs/gcc/Language-Independent-Options.html#Language-Independent-Options
>>>
>>>
>>>
>>> It should be something like "Diagnostic Message Formatting Options"
>>> not "Language Independent Options".
>>>
>>> The misnomer makes the TOC and navbar confusing and seems to suggest
>>> that warning and debuging options are not language independent, since
>>> they're not part of that node. See
>>> https://gcc.gnu.org/onlinedocs/gcc/Invoking-GCC.html#Invoking-GCC
>>> which has:
>>>
>>> * Language Independent Options: Controlling how diagnostics should be
>>> formatted.
>>> * Warning Options: How picky should the compiler be?
>>> * Debugging Options: Symbol tables, measurements, and debugging dumps.
>>> * Optimize Options: How much optimization?
>>> The title of the first entry is completely unrelated to its
>>> description.
>>>
>>> An alternative fix would be to keep a "Language Independent Options"
>>> node but nest "Diagnostic Message Formatting Options", "Warning
>>> Options", "Debugging Options" and "Optimize Options" as sub-sections
>>> of it. The downside of that is that it would be harder to find those
>>> sub-sections from the
>>> https://gcc.gnu.org/onlinedocs/gcc/Invoking-GCC.html#Invoking-GCC
>>> node, as you'd have to click through to another page to see the
>>> sub-sections.
>>>
>>> OK for trunk?
>>
>> I agree with the proposed renaming of the node, but you need to fix
>> all the references to the old name and not just the @node, so no, the
>> patch is not OK as-is.
>
> Ah yes, this should do it.

This version is OK -- thanks for fixing this!

-Sandra

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2015-07-22  0:07 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-07-21 12:54 [doc patch] Rename "Language Independent Options" @node in invoke.texi Jonathan Wakely
2015-07-21 15:37 ` Sandra Loosemore
2015-07-22  0:07   ` Jonathan Wakely
2015-07-22  7:08     ` Sandra Loosemore

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).