From: Paolo Carlini <paolo.carlini@oracle.com>
To: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Cc: Jason Merrill <jason@redhat.com>
Subject: [Ping] Re: [C++ Patch/RFC] PR 53184
Date: Wed, 22 Jul 2015 17:13:00 -0000 [thread overview]
Message-ID: <55AFCD65.6090000@oracle.com> (raw)
In-Reply-To: <5549350B.3050504@oracle.com>
Hi,
On 05/05/2015 11:24 PM, Paolo Carlini wrote:
> Hi,
>
> per the audit trail, this issue appears to boil down to two separate
> issues:
> - The warning doesn't appear universally useful, thus it would be nice
> to give it a name in order to enable disabling it.
> - As shown by the testcase, sometimes the wording is misleading: it
> talks about 'anonymous namespace', where, as clarified by Jason in the
> trail, the issue is really about a type with no linkage, no namespace
> involved.
>
> - The former is easy done, I picked: -Wsubobject-linkage. Makes sense?
> - The latter is a little more tricky, because it doesn't seem always
> easy to tell one case from the other, in particular when templates are
> involved (eg, g++.dg/warn/anonymous-namespace-3.C) and the linkage
> issue involves template arguments. Given that the warning doesn't seem
> terribly important (as another data point, clang doesn't have it), so
> far I have conditionals which reliably figure out cases of anonymous
> namespace and cases of no linkage (per the testcase at issue, for
> example) and otherwise fall back to an 'or' wording. I hope the
> improvement is good enough. Alternately, I suppose the warning could
> use a completely different, more generic, wording, but in that case
> testcases like anonymous-namespace-3.C will need adjustment.
Any feedback on this?
https://gcc.gnu.org/ml/gcc-patches/2015-05/msg00370.html
Thanks!
Paolo.
prev parent reply other threads:[~2015-07-22 17:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-05 21:24 Paolo Carlini
2015-07-22 17:13 ` Paolo Carlini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55AFCD65.6090000@oracle.com \
--to=paolo.carlini@oracle.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jason@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).