From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 84078 invoked by alias); 23 Jul 2015 19:48:35 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 84067 invoked by uid 89); 23 Jul 2015 19:48:34 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 23 Jul 2015 19:48:28 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id DA0308B136; Thu, 23 Jul 2015 19:48:26 +0000 (UTC) Received: from localhost.localdomain (ovpn-113-54.phx2.redhat.com [10.3.113.54]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t6NJmQgp004115; Thu, 23 Jul 2015 15:48:26 -0400 Subject: Re: [PATCH 1/2] Allow REG_EQUAL for ZERO_EXTRACT To: Kugan , Maxim Kuvyrkov References: <558FD9D5.9070703@linaro.org> <558FDA78.9030606@linaro.org> <559212EF.7080301@linaro.org> <44190061-8CD0-417F-8592-23EC3C0BB9A3@linaro.org> <5599BAE4.80103@linaro.org> <559AEF4C.6060506@redhat.com> <55AC685A.8080906@linaro.org> Cc: "gcc-patches@gcc.gnu.org" From: Jeff Law Message-ID: <55B14509.4080609@redhat.com> Date: Thu, 23 Jul 2015 19:57:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.0.1 MIME-Version: 1.0 In-Reply-To: <55AC685A.8080906@linaro.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2015-07/txt/msg01975.txt.bz2 On 07/19/2015 09:17 PM, Kugan wrote: > I have made a mistake while addressing the review comments for this > patch. Unfortunately, It was not detected in my earlier testing. My > sincere graphology for the mistake. > > I have basically missed the STRICT_LOW_PART check for the first if-check > thus the second part (which is the ZERO_EXTRACT part) will never get > executed. Attached patch fixes this along with some minor changes. > > Bootstrapped and regression tested on arm-none-linux (Chromebook) and > x86-64-linux-gnu with no new regression along with the ARM ennoblement > patch. > > Also did a complete arm qemu regression testing with Chriophe's scripts > with no new regression. > (http://people.linaro.org/~christophe.lyon/cross-validation/gcc-test-patches/225987-reg4/report-build-info.html) > > Is this OK for trunk, > > > Thanks, > Kugan > > gcc/ChangeLog: > > 2015-07-20 Kugan Vivekanandarajah > > * cse.c (cse_insn): Fix missing check for STRICT_LOW_PART and minor > clean up. OK. jeff