From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 57872 invoked by alias); 23 Jul 2015 20:35:57 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 57858 invoked by uid 89); 23 Jul 2015 20:35:57 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 23 Jul 2015 20:35:55 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id 29E759024E; Thu, 23 Jul 2015 20:35:54 +0000 (UTC) Received: from localhost.localdomain (ovpn-113-54.phx2.redhat.com [10.3.113.54]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t6NK92AP009048; Thu, 23 Jul 2015 16:09:03 -0400 Subject: Re: [PATCH, PR ipa/66566] Fix ICE in early_inliner: internal compiler error: in operator[] To: Ilya Enkovich , gcc-patches References: <20150618095415.GA28183@msticlxl57.ims.intel.com> Cc: Jan Hubicka From: Jeff Law Message-ID: <55B149DE.30204@redhat.com> Date: Thu, 23 Jul 2015 20:48:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.0.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-07/txt/msg01981.txt.bz2 On 07/20/2015 06:08 AM, Ilya Enkovich wrote: > Ping > > 2015-07-13 11:47 GMT+03:00 Ilya Enkovich : >> Ping >> >> 2015-06-18 12:54 GMT+03:00 Ilya Enkovich : >>> Hi, >>> >>> In early_inliner we do recompute inline summaries for edges after optimize_inline_calls, but check this summary exists in case new edges appear. But then it calls inline_update_overall_summary which also going through edges inline summaries but with no check this time causing segfault. This patch fixes it. Bootstrapped and regtested for x86_64-unknown-linux-gnu. Is it OK for trunk and gcc-5-branch? >>> >>> Thanks, >>> Ilya >>> -- >>> gcc/ >>> >>> 2015-06-18 Ilya Enkovich >>> >>> PR ipa/66566 >>> * ipa-inline-analysis.c (estimate_calls_size_and_time): Check >>> edge summary is available. >>> >>> gcc/testsuite/ >>> >>> 2015-06-18 Ilya Enkovich >>> >>> PR ipa/66566 >>> * gcc.target/i386/mpx/pr66566.c: New test. OK. jeff