public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Matthew Wahab <matthew.wahab@foss.arm.com>
To: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH 4/4][ARM][PR target/65697][5.1] Fix tests for __sync_builtins.
Date: Mon, 27 Jul 2015 10:43:00 -0000	[thread overview]
Message-ID: <55B608CA.3060702@foss.arm.com> (raw)
In-Reply-To: <55953A36.3050807@foss.arm.com>

[-- Attachment #1: Type: text/plain, Size: 1067 bytes --]

Ping. Updated patch attached.

Also, retested for arm-none-linux-gnueabihf with native bootstrap and make
check and for arm-none-eabi with cross compiled make check.

On 02/07/15 14:18, Matthew Wahab wrote:
> This patch backports fixes for the __sync builtin tests.
>
> The trunk patch submission is at
> https://gcc.gnu.org/ml/gcc-patches/2015-07/msg00031.html
> The commit is at https://gcc.gnu.org/ml/gcc-cvs/2015-07/msg00025.html
>
> Tested the series for arm-none-linux-gnueabihf with check-gcc
>
> Ok for the branch?
> Matthew
>
> gcc/testsuite
> 2015-07-02  Matthew Wahab  <matthew.wahab@arm.com>
>
>      Backport from trunk:
>      2015-07-01  Matthew Wahab  <matthew.wahab@arm.com>
>
>      * gcc.target/arm/armv8-sync-comp-swap.c: Replace
>      'do-require-effective-target' with 'dg-require-effective-target'.
>      * gcc.target/arm/armv8-sync-op-full.c: Likewise.
>      * gcc.target/arm/armv8-sync-op-release.c: Likewise.
>      * gcc.target/arm/armv8-sync-op-acquire.c: Likewise.  Also, replace
>      'stlex' with 'strex' as the expected output.
>


[-- Attachment #2: 0004-2015-07-01-Matthew-Wahab-matthew.wahab-arm.com.patch --]
[-- Type: text/x-patch, Size: 3290 bytes --]

From d058686fe1027927a5fdfbb81a83526e3f9b9d6d Mon Sep 17 00:00:00 2001
From: mwahab <mwahab@138bc75d-0d04-0410-961f-82ee72b054a4>
Date: Wed, 1 Jul 2015 12:16:01 +0000
Subject: [PATCH 4/4] 2015-07-01  Matthew Wahab  <matthew.wahab@arm.com>

	Backport
	* gcc.target/arm/armv8-sync-comp-swap.c: Replace
	'do-require-effective-target' with 'dg-require-effective-target'.
	* gcc.target/arm/armv8-sync-op-full.c: Likewise.
	* gcc.target/arm/armv8-sync-op-release.c: Likewise.
	* gcc.target/arm/armv8-sync-op-acquire.c: Likewise.  Also, replace
        'stlex' with 'strex' as the expected output.

git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@225241 138bc75d-0d04-0410-961f-82ee72b054a4

Conflicts:
	gcc/testsuite/ChangeLog

Change-Id: I19f2013f7bdd2dd035f36f0f7c9829cf6a86fb8e
---
 gcc/testsuite/gcc.target/arm/armv8-sync-comp-swap.c  | 2 +-
 gcc/testsuite/gcc.target/arm/armv8-sync-op-acquire.c | 4 ++--
 gcc/testsuite/gcc.target/arm/armv8-sync-op-full.c    | 2 +-
 gcc/testsuite/gcc.target/arm/armv8-sync-op-release.c | 2 +-
 4 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/gcc/testsuite/gcc.target/arm/armv8-sync-comp-swap.c b/gcc/testsuite/gcc.target/arm/armv8-sync-comp-swap.c
index f96c81a..0e95986 100644
--- a/gcc/testsuite/gcc.target/arm/armv8-sync-comp-swap.c
+++ b/gcc/testsuite/gcc.target/arm/armv8-sync-comp-swap.c
@@ -1,5 +1,5 @@
 /* { dg-do compile } */
-/* { do-require-effective-target arm_arch_v8a_ok } */
+/* { dg-require-effective-target arm_arch_v8a_ok } */
 /* { dg-options "-O2" } */
 /* { dg-add-options arm_arch_v8a } */
 
diff --git a/gcc/testsuite/gcc.target/arm/armv8-sync-op-acquire.c b/gcc/testsuite/gcc.target/arm/armv8-sync-op-acquire.c
index 8d6659b..c448599 100644
--- a/gcc/testsuite/gcc.target/arm/armv8-sync-op-acquire.c
+++ b/gcc/testsuite/gcc.target/arm/armv8-sync-op-acquire.c
@@ -1,10 +1,10 @@
 /* { dg-do compile } */
-/* { do-require-effective-target arm_arch_v8a_ok } */
+/* { dg-require-effective-target arm_arch_v8a_ok } */
 /* { dg-options "-O2" } */
 /* { dg-add-options arm_arch_v8a } */
 
 #include "../aarch64/sync-op-acquire.x"
 
 /* { dg-final { scan-assembler-times "ldrex" 1 } } */
-/* { dg-final { scan-assembler-times "stlex" 1 } } */
+/* { dg-final { scan-assembler-times "strex" 1 } } */
 /* { dg-final { scan-assembler-times "dmb" 1 } } */
diff --git a/gcc/testsuite/gcc.target/arm/armv8-sync-op-full.c b/gcc/testsuite/gcc.target/arm/armv8-sync-op-full.c
index a5ad3bd..cce9e00 100644
--- a/gcc/testsuite/gcc.target/arm/armv8-sync-op-full.c
+++ b/gcc/testsuite/gcc.target/arm/armv8-sync-op-full.c
@@ -1,5 +1,5 @@
 /* { dg-do compile } */
-/* { do-require-effective-target arm_arch_v8a_ok } */
+/* { dg-require-effective-target arm_arch_v8a_ok } */
 /* { dg-options "-O2" } */
 /* { dg-add-options arm_arch_v8a } */
 
diff --git a/gcc/testsuite/gcc.target/arm/armv8-sync-op-release.c b/gcc/testsuite/gcc.target/arm/armv8-sync-op-release.c
index 0d3be7b..502a266 100644
--- a/gcc/testsuite/gcc.target/arm/armv8-sync-op-release.c
+++ b/gcc/testsuite/gcc.target/arm/armv8-sync-op-release.c
@@ -1,5 +1,5 @@
 /* { dg-do compile } */
-/* { do-require-effective-target arm_arch_v8a_ok } */
+/* { dg-require-effective-target arm_arch_v8a_ok } */
 /* { dg-options "-O2" } */
 /* { dg-add-options arm_arch_v8a } */
 
-- 
1.9.1


  reply	other threads:[~2015-07-27 10:32 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-02 13:12 [PATCH 1/4][ARM][PR target/65697][5.1] Backport stronger barriers for __sync fetch-op builtins Matthew Wahab
2015-07-02 13:15 ` [PATCH 2/4][ARM][PR target/65697][5.1] Backport stronger barriers for __sync,compare-and-swap builtins Matthew Wahab
2015-07-27 10:32   ` Matthew Wahab
2015-07-31  9:41     ` Ramana Radhakrishnan
2015-07-02 13:17 ` [PATCH 3/4][ARM][PR target/65697][5.1] Add tests for __sync_builtins Matthew Wahab
2015-07-27 10:32   ` Matthew Wahab
2015-07-31  9:41     ` Ramana Radhakrishnan
2015-07-02 13:18 ` [PATCH 4/4][ARM][PR target/65697][5.1] Fix " Matthew Wahab
2015-07-27 10:43   ` Matthew Wahab [this message]
2015-07-31  9:49     ` Ramana Radhakrishnan
2015-07-27 10:31 ` [PATCH 1/4][ARM][PR target/65697][5.1] Backport stronger barriers for __sync fetch-op builtins Matthew Wahab
2015-07-31  9:39   ` Ramana Radhakrishnan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55B608CA.3060702@foss.arm.com \
    --to=matthew.wahab@foss.arm.com \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).