From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 125543 invoked by alias); 27 Jul 2015 14:17:39 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 125521 invoked by uid 89); 27 Jul 2015 14:17:39 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 X-HELO: eu-smtp-delivery-143.mimecast.com Received: from eu-smtp-delivery-143.mimecast.com (HELO eu-smtp-delivery-143.mimecast.com) (146.101.78.143) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 27 Jul 2015 14:17:38 +0000 Received: from cam-owa1.Emea.Arm.com (fw-tnat.cambridge.arm.com [217.140.96.140]) by eu-smtp-1.mimecast.com with ESMTP id uk-mta-33-llK9MtJdSoaegQwqWq3SGg-1; Mon, 27 Jul 2015 15:17:33 +0100 Received: from [10.2.207.50] ([10.1.2.79]) by cam-owa1.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.3959); Mon, 27 Jul 2015 15:17:33 +0100 Message-ID: <55B63D7D.5090703@arm.com> Date: Mon, 27 Jul 2015 14:30:00 -0000 From: Kyrill Tkachov User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Alan Lawrence , "gcc-patches@gcc.gnu.org" Subject: Re: [PATCH 2/16][ARM] PR/63870 Add __builtin_arm_lane_check. References: <559BC74E.6090804@arm.com> In-Reply-To: <559BC74E.6090804@arm.com> X-MC-Unique: llK9MtJdSoaegQwqWq3SGg-1 Content-Type: text/plain; charset=WINDOWS-1252; format=flowed Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2015-07/txt/msg02257.txt.bz2 Hi Alan, On 07/07/15 13:34, Alan Lawrence wrote: > As per https://gcc.gnu.org/ml/gcc-patches/2015-04/msg01334.html + if (fcode =3D=3D ARM_BUILTIN_NEON_LANE_CHECK) + { + tree nlanes =3D CALL_EXPR_ARG (exp, 0); + gcc_assert (TREE_CODE (nlanes) =3D=3D INTEGER_CST); + rtx lane_idx =3D expand_normal (CALL_EXPR_ARG (exp, 1)); + if (CONST_INT_P (lane_idx)) + neon_lane_bounds (lane_idx, 0, TREE_INT_CST_LOW (nlanes), exp); + else + error ("%Klane index must be a constant immediate", exp); + /* Don't generate any RTL. */ + return const0_rtx; + } Can you please add a comment on top of this saying that this builtin only e= xists to perform the lane check, just to make it explicit for the future. Ok with a comment added. Thanks, Kyrill