public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* Re: rx: remove some asserts
@ 2015-07-28  8:14 Nicholas Clifton
  2015-08-08  1:09 ` DJ Delorie
  0 siblings, 1 reply; 3+ messages in thread
From: Nicholas Clifton @ 2015-07-28  8:14 UTC (permalink / raw)
  To: DJ Delorie; +Cc: GCC Patches

Hi DJ,

There is no need to assert these just to say "not supported" and gcc
may rarely generate addresses from valid code which trigger these
asserts.  Ok?

OK - please apply.

Cheers
   Nick

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: rx: remove some asserts
  2015-07-28  8:14 rx: remove some asserts Nicholas Clifton
@ 2015-08-08  1:09 ` DJ Delorie
  0 siblings, 0 replies; 3+ messages in thread
From: DJ Delorie @ 2015-08-08  1:09 UTC (permalink / raw)
  To: Nicholas Clifton; +Cc: gcc-patches


> Hi DJ,
> 
> There is no need to assert these just to say "not supported" and gcc
> may rarely generate addresses from valid code which trigger these
> asserts.  Ok?
> 
> OK - please apply.

Thanks, committed.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* rx: remove some asserts
@ 2015-07-20 21:04 DJ Delorie
  0 siblings, 0 replies; 3+ messages in thread
From: DJ Delorie @ 2015-07-20 21:04 UTC (permalink / raw)
  To: nickc, gcc-patches


Nick,

There is no need to assert these just to say "not supported" and gcc
may rarely generate addresses from valid code which trigger these
asserts.  Ok?

Index: gcc/config/rx/rx.c
===================================================================
--- gcc/config/rx/rx.c	(revision 225533)
+++ gcc/config/rx/rx.c	(working copy)
@@ -367,14 +367,12 @@ rx_mode_dependent_address_p (const_rtx a
 
 	case SYMBOL_REF:
 	case LABEL_REF:
 	  return true;
 
 	case MULT:
-	  gcc_assert (REG_P (XEXP (addr, 0)));
-	  gcc_assert (CONST_INT_P (XEXP (addr, 1)));
 	  /* REG+REG*SCALE is always mode dependent.  */
 	  return true;
 
 	default:
 	  /* Not recognized, so treat as mode dependent.  */
 	  return true;

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-08-08  1:09 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-07-28  8:14 rx: remove some asserts Nicholas Clifton
2015-08-08  1:09 ` DJ Delorie
  -- strict thread matches above, loose matches on Subject: below --
2015-07-20 21:04 DJ Delorie

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).