public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: "François Dumont" <frs.dumont@gmail.com>
To: "libstdc++@gcc.gnu.org" <libstdc++@gcc.gnu.org>,
	 gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: Elimitate duplication of get_catalogs in different abi
Date: Thu, 30 Jul 2015 21:00:00 -0000	[thread overview]
Message-ID: <55BA81B1.9030206@gmail.com> (raw)
In-Reply-To: <55B694F5.3070606@gmail.com>

It seems that this patch results in unresolved symbols.

I am quite sure that the code is right but build system should be adapted.

I noticed that *_cow.cc files are built with -fimplicit-templates. I try
to apply the same with the old abi but I still experiment unresolved
symbols.

Any help is welcome.

François


On 27/07/2015 22:30, François Dumont wrote:
> Hi
>
>     This is the patch to get rid of the duplication of the get_catalogs
> functions in the .so.
>
>     I used c++locale_internal.h that seems to be there for this kind of
> purpose.
>
>     * config/locale/gnu/messages_members.cc (Catalog_info, Catalogs):
>     Move...
>     * config/locale/gnu/c++locale_internal.h: ...here in std namespace.
>     * config/locale/gnu/c_locale.cc: Move implementation of latter here.
>
>     Tested under linux x86_64.
>
>     Ok to commit ?
>
> François
>

  reply	other threads:[~2015-07-30 19:57 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-27 21:01 François Dumont
2015-07-30 21:00 ` François Dumont [this message]
2015-08-05 20:57   ` Jonathan Wakely
2015-08-22  3:23     ` François Dumont
2015-08-22 12:47       ` Daniel Krügler
2015-09-06  9:57         ` François Dumont
2015-09-23 20:24           ` François Dumont
2015-09-25 15:41             ` Jonathan Wakely
2015-09-25 15:46               ` Jonathan Wakely
2015-09-25 17:26                 ` Jonathan Wakely
2015-09-29 20:17                   ` François Dumont
2015-09-30 11:01                     ` Jonathan Wakely

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55BA81B1.9030206@gmail.com \
    --to=frs.dumont@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=libstdc++@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).