From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 41615 invoked by alias); 30 Jul 2015 19:57:43 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 41596 invoked by uid 89); 30 Jul 2015 19:57:42 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: mail-wi0-f170.google.com Received: from mail-wi0-f170.google.com (HELO mail-wi0-f170.google.com) (209.85.212.170) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Thu, 30 Jul 2015 19:57:42 +0000 Received: by wibud3 with SMTP id ud3so33816413wib.1; Thu, 30 Jul 2015 12:57:39 -0700 (PDT) X-Received: by 10.180.7.129 with SMTP id j1mr9789891wia.39.1438286259056; Thu, 30 Jul 2015 12:57:39 -0700 (PDT) Received: from [192.168.0.22] (arf62-1-82-237-250-248.fbx.proxad.net. [82.237.250.248]) by smtp.googlemail.com with ESMTPSA id bd9sm717790wib.18.2015.07.30.12.57.37 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 30 Jul 2015 12:57:38 -0700 (PDT) Message-ID: <55BA81B1.9030206@gmail.com> Date: Thu, 30 Jul 2015 21:00:00 -0000 From: =?UTF-8?B?RnJhbsOnb2lzIER1bW9udA==?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: "libstdc++@gcc.gnu.org" , gcc-patches Subject: Re: Elimitate duplication of get_catalogs in different abi References: <55B694F5.3070606@gmail.com> In-Reply-To: <55B694F5.3070606@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-SW-Source: 2015-07/txt/msg02598.txt.bz2 It seems that this patch results in unresolved symbols. I am quite sure that the code is right but build system should be adapted. I noticed that *_cow.cc files are built with -fimplicit-templates. I try to apply the same with the old abi but I still experiment unresolved symbols. Any help is welcome. François On 27/07/2015 22:30, François Dumont wrote: > Hi > > This is the patch to get rid of the duplication of the get_catalogs > functions in the .so. > > I used c++locale_internal.h that seems to be there for this kind of > purpose. > > * config/locale/gnu/messages_members.cc (Catalog_info, Catalogs): > Move... > * config/locale/gnu/c++locale_internal.h: ...here in std namespace. > * config/locale/gnu/c_locale.cc: Move implementation of latter here. > > Tested under linux x86_64. > > Ok to commit ? > > François >