From: Ramana Radhakrishnan <ramana.radhakrishnan@foss.arm.com>
To: Matthew Wahab <matthew.wahab@foss.arm.com>, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH 1/4][ARM][PR target/65697][5.1] Backport stronger barriers for __sync fetch-op builtins.
Date: Fri, 31 Jul 2015 09:39:00 -0000 [thread overview]
Message-ID: <55BB4184.80909@foss.arm.com> (raw)
In-Reply-To: <55B60823.6070905@foss.arm.com>
On 27/07/15 11:29, Matthew Wahab wrote:
> Ping. Updated patch attached.
>
> Also, retested for arm-none-linux-gnueabihf with native bootstrap and make
> check and for arm-none-eabi with cross compiled make check.
>
> On 02/07/15 14:12, Matthew Wahab wrote:
>> The __sync builtins are implemented using barriers that are too weak for ARMv8
>> targets, this has been fixed on trunk for the ARM back-end. Since GCC-5.1 is
>> also generating the incorrect code, it should also be fixed.
>>
>> This patch backports the changes made to strengthen the barriers emitted for
>> the __sync fetch-and-op/op-and-fetch builtins.
>>
>> The trunk patch submission is at
>> https://gcc.gnu.org/ml/gcc-patches/2015-06/msg01410.html
>> The commit is at https://gcc.gnu.org/ml/gcc-cvs/2015-06/msg01235.html
>>
>> Tested the series for arm-none-linux-gnueabihf with check-gcc
>>
>> Ok for the branch?
>> Matthew
>>
>> 2015-07-02 Matthew Wahab <matthew.wahab@arm.com>
>>
>> Backport from trunk:
>> 2015-06-29 Matthew Wahab <matthew.wahab@arm.com>
>>
>> PR target/65697
>> * config/armc/arm.c (arm_split_atomic_op): For ARMv8, replace an
>> initial acquire barrier with final barrier.
>
This is OK thanks,
Ramana
prev parent reply other threads:[~2015-07-31 9:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-02 13:12 Matthew Wahab
2015-07-02 13:15 ` [PATCH 2/4][ARM][PR target/65697][5.1] Backport stronger barriers for __sync,compare-and-swap builtins Matthew Wahab
2015-07-27 10:32 ` Matthew Wahab
2015-07-31 9:41 ` Ramana Radhakrishnan
2015-07-02 13:17 ` [PATCH 3/4][ARM][PR target/65697][5.1] Add tests for __sync_builtins Matthew Wahab
2015-07-27 10:32 ` Matthew Wahab
2015-07-31 9:41 ` Ramana Radhakrishnan
2015-07-02 13:18 ` [PATCH 4/4][ARM][PR target/65697][5.1] Fix " Matthew Wahab
2015-07-27 10:43 ` Matthew Wahab
2015-07-31 9:49 ` Ramana Radhakrishnan
2015-07-27 10:31 ` [PATCH 1/4][ARM][PR target/65697][5.1] Backport stronger barriers for __sync fetch-op builtins Matthew Wahab
2015-07-31 9:39 ` Ramana Radhakrishnan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55BB4184.80909@foss.arm.com \
--to=ramana.radhakrishnan@foss.arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=matthew.wahab@foss.arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).