From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11513 invoked by alias); 31 Jul 2015 09:36:09 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 11502 invoked by uid 89); 31 Jul 2015 09:36:08 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: foss.arm.com Received: from foss.arm.com (HELO foss.arm.com) (217.140.101.70) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 31 Jul 2015 09:36:07 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6798775 for ; Fri, 31 Jul 2015 02:36:13 -0700 (PDT) Received: from [10.2.206.27] (e105545-lin.cambridge.arm.com [10.2.206.27]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id CF5F23F318; Fri, 31 Jul 2015 02:36:05 -0700 (PDT) Message-ID: <55BB4184.80909@foss.arm.com> Date: Fri, 31 Jul 2015 09:39:00 -0000 From: Ramana Radhakrishnan User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Matthew Wahab , gcc-patches@gcc.gnu.org Subject: Re: [PATCH 1/4][ARM][PR target/65697][5.1] Backport stronger barriers for __sync fetch-op builtins. References: <559538D3.8010302@foss.arm.com> <55B60823.6070905@foss.arm.com> In-Reply-To: <55B60823.6070905@foss.arm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-07/txt/msg02634.txt.bz2 On 27/07/15 11:29, Matthew Wahab wrote: > Ping. Updated patch attached. > > Also, retested for arm-none-linux-gnueabihf with native bootstrap and make > check and for arm-none-eabi with cross compiled make check. > > On 02/07/15 14:12, Matthew Wahab wrote: >> The __sync builtins are implemented using barriers that are too weak for ARMv8 >> targets, this has been fixed on trunk for the ARM back-end. Since GCC-5.1 is >> also generating the incorrect code, it should also be fixed. >> >> This patch backports the changes made to strengthen the barriers emitted for >> the __sync fetch-and-op/op-and-fetch builtins. >> >> The trunk patch submission is at >> https://gcc.gnu.org/ml/gcc-patches/2015-06/msg01410.html >> The commit is at https://gcc.gnu.org/ml/gcc-cvs/2015-06/msg01235.html >> >> Tested the series for arm-none-linux-gnueabihf with check-gcc >> >> Ok for the branch? >> Matthew >> >> 2015-07-02 Matthew Wahab >> >> Backport from trunk: >> 2015-06-29 Matthew Wahab >> >> PR target/65697 >> * config/armc/arm.c (arm_split_atomic_op): For ARMv8, replace an >> initial acquire barrier with final barrier. > This is OK thanks, Ramana