From: Jeff Law <law@redhat.com>
To: Andrew MacLeod <amacleod@redhat.com>,
gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [patch] Move symbol_visibility to coretypes.h
Date: Fri, 31 Jul 2015 16:07:00 -0000 [thread overview]
Message-ID: <55BB9793.8070702@redhat.com> (raw)
In-Reply-To: <55BA22E6.4010909@redhat.com>
On 07/30/2015 07:13 AM, Andrew MacLeod wrote:
> Pretty simple. Both flag-types.h and tree-core.h check to see if the
> other header has already defined this enumerated type, and defined it if
> not.
>
> Its an unnecessary conditional compilation and dual maintenance of this
> small enum. This patch puts it in coretypes.h and makes it always
> available.
>
> Bootstraps on x86_64-pc-linux-gnu with no new regressions. Ok for trunk?
OK.
jeff
prev parent reply other threads:[~2015-07-31 15:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-30 14:09 Andrew MacLeod
2015-07-31 16:07 ` Jeff Law [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55BB9793.8070702@redhat.com \
--to=law@redhat.com \
--cc=amacleod@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).