From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 67335 invoked by alias); 31 Jul 2015 15:43:20 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 67131 invoked by uid 89); 31 Jul 2015 15:43:19 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 31 Jul 2015 15:43:18 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id E4FCD36B1ED for ; Fri, 31 Jul 2015 15:43:16 +0000 (UTC) Received: from localhost.localdomain (ovpn-113-21.phx2.redhat.com [10.3.113.21]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t6VFhGOB005120; Fri, 31 Jul 2015 11:43:16 -0400 Subject: Re: [patch] Move symbol_visibility to coretypes.h To: Andrew MacLeod , gcc-patches References: <55BA22E6.4010909@redhat.com> From: Jeff Law Message-ID: <55BB9793.8070702@redhat.com> Date: Fri, 31 Jul 2015 16:07:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <55BA22E6.4010909@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-07/txt/msg02678.txt.bz2 On 07/30/2015 07:13 AM, Andrew MacLeod wrote: > Pretty simple. Both flag-types.h and tree-core.h check to see if the > other header has already defined this enumerated type, and defined it if > not. > > Its an unnecessary conditional compilation and dual maintenance of this > small enum. This patch puts it in coretypes.h and makes it always > available. > > Bootstraps on x86_64-pc-linux-gnu with no new regressions. Ok for trunk? OK. jeff