From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 35676 invoked by alias); 31 Jul 2015 16:48:19 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 35666 invoked by uid 89); 31 Jul 2015 16:48:18 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.7 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 31 Jul 2015 16:48:13 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id 25213A756B; Fri, 31 Jul 2015 16:48:12 +0000 (UTC) Received: from [10.10.116.17] ([10.10.116.17]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t6VGmBbg019765; Fri, 31 Jul 2015 12:48:11 -0400 Subject: Re: C++ delayed folding branch review To: Jakub Jelinek , Kai Tietz References: <557BAE5A.7030309@redhat.com> <55B661A1.6090308@redhat.com> <55B911DD.30105@redhat.com> <55BA5667.9040200@redhat.com> <55BAE20A.1070400@redhat.com> <55BB9EDB.8030305@redhat.com> <20150731164638.GH1780@tucnak.redhat.com> Cc: Jeff Law , Kai Tietz , gcc-patches List From: Jason Merrill Message-ID: <55BBA6C1.4000105@redhat.com> Date: Fri, 31 Jul 2015 16:53:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <20150731164638.GH1780@tucnak.redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2015-07/txt/msg02694.txt.bz2 On 07/31/2015 12:46 PM, Jakub Jelinek wrote: > On Fri, Jul 31, 2015 at 06:25:57PM +0200, Kai Tietz wrote: >> 2015-07-31 18:14 GMT+02:00 Jason Merrill : >>> On 07/30/2015 10:48 PM, Jeff Law wrote: >>>> >>>> Note, anything outside of the C/C++ front-ends depending on that >>>> canonicalization done by shorten_compare is, IMHO, broken. >>> >>> I think the OMP code isn't relying on it being done by shorten_compare; it's >>> trying to do it itself in c_finish_omp_for but is somehow thwarted by >>> delayed folding. >> >> Well, this seems to be reasoned by finish_omp_for (), which gets >> invoked in parser.c cp_parser_omp_for_loop, and/or pt.c: tsubst_expr. >> In all those cases arguments aren't folded anymore. So >> c_finish_omp_for's patterns don't match anymore. I guess we might >> want to do this cannonical form in genericize-pass? > > Or just fold in finish_omp_for before calling c_finish_omp_for, so that it > is in the expected form? That certainly sounds simpler. Jason