From: Jeff Law <law@redhat.com>
To: Patrick Palka <patrick@parcs.ath.cx>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>,
David Malcolm <dmalcolm@redhat.com>
Subject: Re: [PATCH 1/3] Refactor entry point to -Wmisleading-indentation
Date: Fri, 31 Jul 2015 16:56:00 -0000 [thread overview]
Message-ID: <55BBA6F2.5060107@redhat.com> (raw)
In-Reply-To: <CA+C-WL-gx_zUoW-LgY9W_4trBOuWJXB=ja8kydLrUTKRcAZMBQ@mail.gmail.com>
On 07/27/2015 05:12 PM, Patrick Palka wrote:
>>>>
>>>> The only question in my mind is bootstrap & regression testing. From
>>>> reading the thread for the earlier version of this patch I got the
>>>> impression you had bootstrapped and regression tested earlier versions.
>>>>
>>>> If you could confirm that you've bootstrapped and regression tested this
>>>> version it'd be appreciated. You can do it on the individual patches or the
>>>> set as a whole.
>>>
>>> I think I successfully bootstrapped + regtested this exact version but
>>> I'm not sure. I was going to do so again before committing anyway.
>>> I will fire off a build tonight and confirm the results tomorrow.
>>
>> Bootstrap + regtest on x86_64-linux-gnu was successful with no new regressions.
>>
>>>
>>>>
>>>> Jeff
>>>>
>>>>
>
> Hi Jeff. Sorry for the late reply. I would like to commit this
> series now (after another bootstrap + regtest cycle) to work on
> further refinements to this warning. You clearly approved the last
> two out of three patches, but it is not clear whether you approved
> this first patch. Could you clarify your stance on this patch?
> Thanks again for reviewing.
Sorry for not being explicit. Yes, patch #1 is fine with the bootstrap
& regression test done.
Thanks,
jeff
prev parent reply other threads:[~2015-07-31 16:48 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-09 17:31 Patrick Palka
2015-06-09 17:31 ` [PATCH 2/3] Remove is_first_nonwhitespace_on_line(), instead improve get_visual_column() Patrick Palka
2015-06-22 17:37 ` Jeff Law
2015-06-09 18:01 ` [PATCH 3/3] Improve -Wmissing-indentation heuristics Patrick Palka
2015-06-18 16:46 ` David Malcolm
2015-06-18 16:58 ` Patrick Palka
2015-06-18 17:15 ` Patrick Palka
2015-06-22 16:51 ` Jeff Law
2015-06-22 17:38 ` Jeff Law
2015-06-18 15:45 ` [PATCH 1/3] Refactor entry point to -Wmisleading-indentation Patrick Palka
2015-06-18 16:48 ` David Malcolm
2015-06-18 17:09 ` Patrick Palka
2015-06-22 16:37 ` Jeff Law
2015-06-22 17:32 ` Jeff Law
2015-06-22 19:03 ` Patrick Palka
2015-06-23 19:14 ` Patrick Palka
2015-07-28 2:36 ` Patrick Palka
2015-07-31 16:56 ` Jeff Law [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55BBA6F2.5060107@redhat.com \
--to=law@redhat.com \
--cc=dmalcolm@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=patrick@parcs.ath.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).