From: Jason Merrill <jason@redhat.com>
To: Nathan Sidwell <nathan@acm.org>, GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [C++/66443] virtual base of abstract class
Date: Mon, 03 Aug 2015 03:44:00 -0000 [thread overview]
Message-ID: <55BEE386.9070103@redhat.com> (raw)
In-Reply-To: <55BD56D0.601@acm.org>
On 08/01/2015 07:31 PM, Nathan Sidwell wrote:
> Ok, this patch fixes things up. The previous version was a little too
> lax, extending the logic of DR1611 to all synthesized functions.
> However, this broke virtual synthesized dtors, in that an abstract
> class's synthesized dtor's exception specification would not take
> account of any virtual base dtor exception specs. This would mean that
> a non-abstract derived class's synthesized dtor might end up with a
> throwing exception spec (because the virtual base's dtor did), and that
> would be looser than the exception spec on the abstract base's
> non-callable synthesized dtor. And that fails the virtual overriding
> checks.
It seems to me that DR 1658 ignores vbases of abstract classes for
determining whether a destructor is deleted, but says nothing about
exception specifications.
DR 1351 specifically ignores vbases of abstract classes for determining
the exception specification of a constructor, but only for constructors.
So I think that for destructors we want to walk the base, but pass in a
fake delete_p.
Why the check for inherited_parms? I would think that inheriting
constructors would be handled like other ctors.
Jason
next prev parent reply other threads:[~2015-08-03 3:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-30 0:10 [C++/66443] Nathan Sidwell
2015-06-30 4:24 ` [C++/66443] Jason Merrill
2015-06-30 23:24 ` [C++/66443] Nathan Sidwell
2015-07-08 14:50 ` [C++/66443] virtual base of abstract class Nathan Sidwell
2015-07-17 19:57 ` Jason Merrill
2015-07-17 20:12 ` Nathan Sidwell
2015-08-01 23:31 ` Nathan Sidwell
2015-08-03 3:44 ` Jason Merrill [this message]
2015-08-03 13:20 ` Nathan Sidwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55BEE386.9070103@redhat.com \
--to=jason@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=nathan@acm.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).