From: Jeff Law <law@redhat.com>
To: Martin Sebor <msebor@gmail.com>, Jan-Benedict Glaw <jbglaw@lug-owl.de>
Cc: Segher Boessenkool <segher@kernel.crashing.org>,
Martin Sebor <msebor@redhat.com>,
Gcc Patch List <gcc-patches@gcc.gnu.org>
Subject: Re: [BUILDROBOT] Go runtime: calling ‘__builtin_frame_address’ with a nonzero argument is unsafe
Date: Mon, 03 Aug 2015 15:29:00 -0000 [thread overview]
Message-ID: <55BF88E4.5030708@redhat.com> (raw)
In-Reply-To: <55BF7F2D.2040605@gmail.com>
On 08/03/2015 08:48 AM, Martin Sebor wrote:
> On 08/03/2015 05:55 AM, Jan-Benedict Glaw wrote:
>> On Sun, 2015-08-02 17:15:27 -0600, Martin Sebor <msebor@gmail.com> wrote:
>>>> OK for the trunk. Sorry for the delay.
>>>
>>> Thank you. Committed in revision 226480.
>>
>> ...und breaks native builds. When doing builds using config-list.mk, I
>> first build a GCC for the build machine, then re-build a
>> cross-configured GCC with that.
>
> I don't know if pragma GCC diagnostic is valid in Go (still waiting
> for my build to finish to confirm) but disabling the warning in
> cases where the calls are known to be safe should fix the compilation
> error.
My understanding is the runtime is shared across gcc-go and golang. So
the push/pop diagnostics may not be appropriate.
Ian Taylor should have the final say about the best way forward.
Jeff
next prev parent reply other threads:[~2015-08-03 15:29 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-21 19:37 [PATCH] clarify doc for __builtin_return_address Martin Sebor
2015-05-21 20:50 ` Sandra Loosemore
2015-05-21 21:22 ` Martin Sebor
2015-05-21 22:00 ` Pedro Alves
2015-06-11 23:22 ` [PATCH] warn for unsafe calls to __builtin_return_address Martin Sebor
2015-06-18 17:32 ` [PING] " Martin Sebor
2015-06-27 0:48 ` [PING 2] " Martin Sebor
2015-07-07 3:41 ` [PING 3] " Martin Sebor
2015-07-07 10:14 ` Pedro Alves
2015-07-24 5:30 ` Jeff Law
2015-07-25 15:59 ` Segher Boessenkool
2015-07-28 3:44 ` Martin Sebor
2015-07-28 15:19 ` Segher Boessenkool
2015-07-28 16:03 ` Martin Sebor
2015-07-31 16:46 ` Jeff Law
2015-08-02 23:15 ` Martin Sebor
2015-08-03 11:55 ` [BUILDROBOT] Go runtime: calling ‘__builtin_frame_address’ with a nonzero argument is unsafe (was: warn for unsafe calls to __builtin_return_address) Jan-Benedict Glaw
2015-08-03 14:48 ` [BUILDROBOT] Go runtime: calling ‘__builtin_frame_address’ with a nonzero argument is unsafe Martin Sebor
2015-08-03 15:29 ` Jeff Law [this message]
2015-08-05 7:28 ` [PATCH] warn for unsafe calls to __builtin_return_address Andreas Schwab
2015-08-05 16:03 ` Jiong Wang
2015-08-05 17:56 ` Martin Sebor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55BF88E4.5030708@redhat.com \
--to=law@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jbglaw@lug-owl.de \
--cc=msebor@gmail.com \
--cc=msebor@redhat.com \
--cc=segher@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).