From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 88252 invoked by alias); 3 Aug 2015 16:59:13 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 88239 invoked by uid 89); 3 Aug 2015 16:59:13 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 03 Aug 2015 16:59:12 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id 108F678; Mon, 3 Aug 2015 16:59:11 +0000 (UTC) Received: from localhost.localdomain (ovpn-113-21.phx2.redhat.com [10.3.113.21]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t73GxAQQ032315; Mon, 3 Aug 2015 12:59:10 -0400 Subject: Re: [PR66726] Factor conversion out of COND_EXPR To: Kugan , Bernhard Reutner-Fischer References: <55974BF2.3060603@linaro.org> <20150704085143.GA14895@nbbrfq.cc.univie.ac.at> <5597D24B.8010900@linaro.org> <559AF515.6010700@redhat.com> <559BCB15.9010209@linaro.org> <559BE505.5070802@redhat.com> <559EFEE5.6030006@linaro.org> <55A02DBF.6030608@redhat.com> <55A24E7D.4080609@linaro.org> <55A6073D.1020800@linaro.org> <55A6AA4D.1030106@redhat.com> <55A74691.3050303@linaro.org> <55B13AF0.3020204@redhat.com> <55B583F6.4080904@linaro.org> Cc: "gcc-patches@gcc.gnu.org" From: Jeff Law Message-ID: <55BF9DDE.6070302@redhat.com> Date: Mon, 03 Aug 2015 16:59:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <55B583F6.4080904@linaro.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-08/txt/msg00099.txt.bz2 On 07/26/2015 07:05 PM, Kugan wrote: > > I thought that when !gimple_assign_cast_p (stmt), RHS will always > boolean. I have now added this check in the attached patch. Thanks. > > I also noticed that in maybe_optimize_range_tests, GIMPLE_COND can > have non compatible types when new_op is updated > (boolean types coming from tcc_compare results) and hence need to be > converted. Changed that as well. Did you find this by examination or with some testcode? If the latter, including a testcase for this issue would be appreciated. > > Bootstrapped and regression tested on x86-64-none-linux-gnu with no new > regressions. Is this OK for trunk? OK with an updated changelog. Jeff